Refactor Catalog API in new API version #680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
Author
|
I have tested the Blazor, Maui, and Hybrid App and all seem to be functioning correctly. Moved to Ready for Review. |
captainsafia
reviewed
Jan 9, 2025
mikekistler
force-pushed
the
mdk/catalog-api-v2
branch
from
4302e65 to
06bce6c
Compare
captainsafia
approved these changes
Jan 10, 2025
emilkvarnhammar
pushed a commit
to oplane/eShopOLD
that referenced
this pull request
Jul 3, 2025
* Add Catalog API v2 with all the same APIs * Split GetAllItems into v1 and v2 * Collapse GetItemsByName, Type, or Brand into GetAllItems * Add id path parameter to UpdateItem * Move text parameter from path to query * Update Catalog clients to V2 API version * Refactor v1 APIs to use V2 implementation * Update ApiVersion of WebAppCatalogService (client) to 2.0 * Address PR review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Catalog API to adopt more commonly accepted REST API conventions. The existing V1 API is unchanged and all refactoring is done in a new API version, V2.
Fixes #589.
Note: I have not tested the clients yet, so will move this to draft until that is done.