Use cloned IDiagnosticsLogger in compiled query cache

[rducom]

Fixes #21016
This PR fixs the memory leak in compiled query cache
It introduce a IDiagnosticsLogger clone used in the QueryingEnumerable code paths, so the Closure held by compiled Func<QueryContext,T> never reference Scoped instances via Interceptors.

I have tried to use a IDiagnosticsLogger singleton, but since ILoggerFactory can be either scoped or singleton, going Singleton for DiagnosticsLogger requires breaking changes.
This "clone way" have minimum impact on the existing code base.

[smitpatel]

This is not the right way to fix this issue.

[rducom]

Ok, what do you suggest ?

[rducom]

I think for 3.1, the fix should implies minimum code changes. If for 5.0 it's possible to do more "breaking" changes, here's what I think it could be :
My main concern is the fact IDiagnosticsLogger are Scoped : I think it should be singleton, or at least, the type injected in each compiled closure should be a singleton (not necessarily IDiagnosticsLogger).
But it requires 3 important changes :

• enforcing IDiagnosticsLogger are thread-safe : if we go for singleton, this instance will be shared by all compiled queries
• enforcing ILoggerFactory as singleton (it have a lot of impacts on the registration)
• moving Interceptors out of IDiagnosticsLogger

Don't hesitate to share insights as I'm certainly missing the best way to implement the fix, and I'll really love trying any other suggested way to fix this.

[rducom]

I've submitted another PR, with another way to fix this issue : #21023