[release/8.0] Contains nullability processing #32265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dotnet#32214) Fixes dotnet#32208 (cherry picked from commit 338b76a)
roji
changed the title
AndriySvyryd
added
Servicing-consider
Servicing-approved
and removed
Servicing-consider
labels
ajcvickers
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32208, backports #32214
Description
When doing SQL nullability processing for an non-subquery InExpression (e.g. Contains LINQ operator), the expression's item was visited but the results were discarded, not being taken into account.
Customer impact
This can cause bugs in any LINQ query containing
x.Contains(y), where y (the item) requires some sort of nullability processing. For example, this causes QueryBugsTest.Nested_contains_with_enum to fail when the SQL compatibility level is set to low (but that's just one example).How found
Customer reported on 8.0
Regression
Yes.
Testing
Added tests.
Risk
Very low; a quirk has been added.