- 
                Notifications
    You must be signed in to change notification settings 
- Fork 3.3k
LEAST/GREATEST nullability work #32458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    maumar
  
              
              previously approved these changes
              
                  
                    Nov 30, 2023 
                  
              
              
            
            
| Turning this into a draft, there are unfortunately some other nullability-related aspects of this that need to be taken care of... | 
594a31d    to
    f1181d9      
    Compare
  
    f1181d9    to
    2fc6828      
    Compare
  
    | Nullability analysisThere are two diverging behaviors across databases with respect to NULL arguments (there's a reason I procrastinated on this work...): 
 We have three cases where we translate to GREATEST/LEAST: 
 Changes in this PR
 | 
| @dotnet/efteam I've brought this back and done the necessary fixed, see above. | 
2fc6828    to
    4e3efed      
    Compare
  
    4e3efed    to
    e70041d      
    Compare
  
    
              
                    cincuranet
  
              
              approved these changes
              
                  
                    Jul 23, 2024 
                  
              
              
            
            
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
@maumar tiny fixup PR; if EF.Functions.Greatest/Least is used over a nullable value type, that trips up the debug assertion (SqlExpression nodes can't have a nullable value type). So this unwraps that before creating the function.
Fixup to #32338