Simplify NOT (CASE ... THEN const) by pushing NOT into the THEN/ELSE #33934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even though it already affects some tests, I am looking for the best place to add tests that specifically check for this transformation. |
|
NorthwindSelect/NorthwindWhere should work, can't go wrong with GearsOfWar either, but that forces duplicating tests into multiple suites. Alternatively, you already have some helpers/infra in the NullSemantics tests, so those could work also. |
maumar
approved these changes
Jun 11, 2024
|
another notch on the belt ;) thanks @ranma42 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the optimization suggested in #33857
Fixes #33857