Move NonNullableConventionState to CoreAnnotationNames #35020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
OTJ73
branch
2 times, most recently
from
1840961 to
121c280
Compare
cincuranet
approved these changes
Nov 11, 2024
This means it gets correctly filtered out when using the model for code generation, and hence we don't try to generate a literal for it. Fixes #34996
| IConventionModelBuilder modelBuilder, | ||
| IConventionContext<IConventionModelBuilder> context) | ||
| => modelBuilder.Metadata.RemoveAnnotation(StateAnnotationName); | ||
| => modelBuilder.Metadata.RemoveAnnotation(CoreAnnotationNames.NonNullableConventionState); |
Member
There was a problem hiding this comment.
Why was the annotation left in the model in the repro? This should've removed it.
Contributor
Author
There was a problem hiding this comment.
ModelFinalizing isn't called on the database model.
Member
There was a problem hiding this comment.
The relational model is produced from the normal model and the normal model should not have this annotation after this convention runs.
How does the annotation end up in the model?
AndriySvyryd
pushed a commit
that referenced
this pull request
Dec 19, 2024
This means it gets correctly filtered out when using the model for code generation, and hence we don't try to generate a literal for it. Fixes #34996
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means it gets correctly filtered out when using the model for code generation, and hence we don't try to generate a literal for it.
Fixes #34996