CanRenderAsync should not have a ref parameter

[stephentoub]

ChatConversationEvaluator has this method:

    protected virtual ValueTask<bool> CanRenderAsync(
        ChatMessage message,
        ref int tokenBudget,
        ChatConfiguration chatConfiguration,
        CancellationToken cancellationToken)

That ref int tokenBudget parameter is problematic. An override of this method can't implement this asynchronously while still correctly handling updating that parameter, as it can only be updated as part of the synchronous invocation of the method.

cc: @shyamnamboodiripad, @peterwald

[peterwald]

Good catch. That seems like a good candidate for an analyzer rule.

[stephentoub]

That seems like a good candidate for an analyzer rule.

It is one, that's how I noticed it. :) It's just only enabled as a suggestion right now in dotnet/extensions.