Skip to content

Remove the ref int parameter from ChatConversationEvaluator.CanRenderAsync() #5896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Remove the ref int parameter from ChatConversationEvaluator.CanRenderAsync() #5896

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/Libraries/Microsoft.Extensions.AI.Evaluation.Quality/ChatConversationEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,10 @@ await RenderEvaluationPromptAsync(
{
if (history.Count == 1)
{
bool canRender =
(bool canRender, tokenBudget) =
await CanRenderAsync(
history[0],
ref tokenBudget,
tokenBudget,
chatConfiguration,
cancellationToken).ConfigureAwait(false);

Expand All @@ -132,10 +132,10 @@ await CanRenderAsync(
{
cancellationToken.ThrowIfCancellationRequested();

bool canRender =
(bool canRender, tokenBudget) =
await CanRenderAsync(
message,
ref tokenBudget,
tokenBudget,
chatConfiguration,
cancellationToken).ConfigureAwait(false);

Expand Down Expand Up @@ -222,12 +222,12 @@ await ParseEvaluationResponseAsync(
/// </param>
/// <param name="cancellationToken">A <see cref="CancellationToken"/> that can cancel the operation.</param>
/// <returns>
/// <see langword="true"/> if there is sufficient <paramref name="tokenBudget"/> remaining to render the supplied
/// <paramref name="message"/> as part of the evaluation prompt; <see langword="false"/> otherwise.
/// A tuple containing a boolean indicating if there is sufficient <paramref name="tokenBudget"/> remaining to render the supplied
/// <paramref name="message"/> as part of the evaluation prompt and an int returning the remaining token budget.
/// </returns>
protected virtual ValueTask<bool> CanRenderAsync(
protected virtual ValueTask<(bool tokenBudgetSufficient, int tokenBudgetRemaining)> CanRenderAsync(
ChatMessage message,
ref int tokenBudget,
int tokenBudget,
ChatConfiguration chatConfiguration,
CancellationToken cancellationToken)
{
Expand All @@ -237,7 +237,7 @@ protected virtual ValueTask<bool> CanRenderAsync(
IEvaluationTokenCounter? tokenCounter = chatConfiguration.TokenCounter;
if (tokenCounter is null)
{
return new ValueTask<bool>(true);
return new ValueTask<(bool, int)>((true, tokenBudget));
}

string? author = message.AuthorName;
Expand All @@ -261,12 +261,12 @@ protected virtual ValueTask<bool> CanRenderAsync(

if (tokenCount > tokenBudget)
{
return new ValueTask<bool>(false);
return new ValueTask<(bool, int)>((false, tokenBudget));
}
else
{
tokenBudget -= tokenCount;
return new ValueTask<bool>(true);
return new ValueTask<(bool, int)>((true, tokenBudget));
}
}

Expand Down