Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Mar 10, 2025

This pull request updates the following dependencies

From https://github.com/dotnet/aspnetcore

Microsoft Reviewers: Open in CodeFlow

…0250307.10

Microsoft.AspNetCore.App.Ref , Microsoft.AspNetCore.App.Runtime.win-x64 , Microsoft.AspNetCore.Mvc.Testing , Microsoft.AspNetCore.TestHost , Microsoft.Extensions.Caching.SqlServer , Microsoft.Extensions.Caching.StackExchangeRedis , Microsoft.Extensions.Diagnostics.HealthChecks , Microsoft.Extensions.Http.Polly , Microsoft.Extensions.ObjectPool
 From Version 10.0.0-preview.3.25151.1 -> To Version 10.0.0-preview.3.25157.10
@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner March 10, 2025 05:02
@sebastienros sebastienros requested a review from a team as a code owner March 10, 2025 16:25
@RussKie
Copy link
Contributor

RussKie commented Mar 10, 2025

These look like a coherency related issues:

test/Libraries/Microsoft.Extensions.Http.Diagnostics.Tests/Microsoft.Extensions.Http.Diagnostics.Tests.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.Extensions.Hosting from 10.0.0-preview.3.25155.12 to 10.0.0-preview.3.25128.5. Reference the package directly from the project to select a different version. 
 Microsoft.Extensions.Http.Diagnostics.Tests -> Microsoft.AspNetCore.Mvc.Testing 10.0.0-preview.3.25157.10 -> Microsoft.Extensions.Hosting (>= 10.0.0-preview.3.25155.12) 
 Microsoft.Extensions.Http.Diagnostics.Tests -> Microsoft.Extensions.Hosting (>= 10.0.0-preview.3.25128.5)

bench/Libraries/Microsoft.Extensions.Telemetry.PerformanceTests/Microsoft.Extensions.Telemetry.PerformanceTests.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: Microsoft.Extensions.Logging from 10.0.0-preview.3.25155.12 to 10.0.0-preview.3.25128.5. Reference the package directly from the project to select a different version. 
 Microsoft.Extensions.Telemetry.PerformanceTests -> Microsoft.AspNetCore.Mvc.Testing 10.0.0-preview.3.25157.10 -> Microsoft.Extensions.Hosting 10.0.0-preview.3.25155.12 -> Microsoft.Extensions.Logging (>= 10.0.0-preview.3.25155.12) 
 Microsoft.Extensions.Telemetry.PerformanceTests -> Microsoft.Extensions.Logging (>= 10.0.0-preview.3.25128.5)

@sebastienros
Copy link
Member

@RussKie

These look like a coherency related issues

Wanted to ask you about it. Is that something common in extension? There are multiple PRs blocked on the aspnetcore repos and since my changes didn't help I also came to this hypothesis (without certainty).

@RussKie
Copy link
Contributor

RussKie commented Mar 10, 2025

Our dependency graph is this: dotnet/extension <-- dotnet/aspnetcore <-- dotnet/runtime

To reduce the number of dependency inflows, we pull only the aspnetcore which brings (or supposed to) the coherent runtime dependencies as well (this is what CoherentParentDependency="Microsoft.AspNetCore.App.Runtime.win-x64" attribute is for in Version.Details.xml). So, the current situation doesn't look normal.... Could it be that in the aspnetcore repo there was a downgrade forced through somehow?

/cc: @wtgodbe

@wtgodbe
Copy link
Member

wtgodbe commented Mar 10, 2025

This is weird - the CoherentParentDependency setup looks right, and the version of Microsoft.Extensions.Hosting in aspnetcore at 8ec8cbf89d61d91f9356192c8b8afea1c9a960c3 is indeed 10.0.0-preview.3.25155.12, but maestro didn't push that update to this PR. Nothing's jumping out at me - @dotnet/dnceng @mmitche any idea why that transitive dependency didn't get updated via the CPD?

https://github.com/dotnet/aspnetcore/blob/8ec8cbf89d61d91f9356192c8b8afea1c9a960c3/eng/Version.Details.xml#L133-L136

@RussKie RussKie closed this Mar 12, 2025
@RussKie RussKie deleted the darc-dev-ce57c3e7-d62d-4c76-bc28-35379d43157a branch March 12, 2025 05:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants