Update OpenTelemetryChatClient to 1.34 #6466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the OpenTelemetry semantic conventions to v1.34 and adds conversation-level tagging to the chat client.
- Introduce a new
Conversation.Idconstant for Gen AI telemetry. - Bump documentation references from v1.33 to v1.34.
- Instrument
OpenTelemetryChatClientto tagConversationIdon streaming responses.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.AI/OpenTelemetryConsts.cs | Added Conversation.Id constant under Gen AI telemetry. |
| src/Libraries/Microsoft.Extensions.AI/Embeddings/OpenTelemetryEmbeddingGenerator.cs | Updated semantic conventions version to v1.34 in remarks. |
| src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs | Updated spec version docs and added tagging of ConversationId on streaming responses. |
Comments suppressed due to low confidence (2)
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs:250
- Consider adding or updating unit/integration tests to verify that
ConversationIdis correctly added as a tag on activities, ensuring your new telemetry behaviour is covered.
if (options.ConversationId is string conversationId)
src/Libraries/Microsoft.Extensions.AI/ChatCompletion/OpenTelemetryChatClient.cs:246
- For consistent telemetry, also apply the
ConversationIdtag in the non-streamingGetResponseAsyncoverride so both chat paths include conversation context.
public override async IAsyncEnumerable<ChatResponseUpdate> GetStreamingResponseA
eiriktsarpalis
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @lmolkova
Microsoft Reviewers: Open in CodeFlow