Remove unnecessary sourcelink dependency #17099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mthalman
approved these changes
Aug 1, 2023
Member
mthalman
left a comment
mthalman
left a comment
There was a problem hiding this comment.
Perhaps also add a comment to the top of the Version.Details file explaining that the order of the dependencies matters and why.
MichaelSimons
approved these changes
Aug 1, 2023
Member
Author
|
Added a comment to |
mthalman
approved these changes
Aug 1, 2023
Member
Author
|
Merging on red as the failure is showing in all recent PRs, i.e. #17103 |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/source-build#3551
sourcelinkdependencies are not needed anymore sincesourcelinkships in .NET 8.0 Preview 6 SDK.arcadehas already updatedsourcelinkconsumption with: dotnet/arcade#13892Source-build consumes repos and their SHAs based on the order of dependencies in
installer's Version.Details.xml and all transitive dependencies expressed in that file. To align with Microsoft built SDK, we need to ensure that source-build gets the samesourcelinkdependency that is consumed bysdkrepo. This necessitates a reorder of package dependencies to getsdkabovetest-templatesastest-templatesstill consumes oldsourcelinkand is running on older Arcade and SDK versions.