Use attributes on lambdas in tests #2682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Use attributes on lambdas in tests * Fix formatting * Unindent attributes Commit migrated from dotnet/linker@93eac59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates a few of the compiler-generated code tests to put the
ExpectedWarningattribute on lambdas and local functions when possible, removing the need forCompilerGeneratedCode = truein these places.Unfortunately the formatting became weird - dotnet format seems to require the lambda to not be indented following the attribute, and I couldn't find a good workaround so I'm leaving it as-is. (Filed dotnet/format#1548) edit: Ok, I changed it to at least unindent the attributes as well to match the lambda expression. Otherwise multiple attributes on lambdas have inconsistent indentation.