Use of NuGet static-graph restore introduces prebuilts in source-build

[MichaelSimons]

This is related to the use of the RestoreUseStaticGraphEvaluation option which was added in #6905. This option does not appear to work well with the MSBuild.SourceBuild.slnf. All of the projects in the main solution appear to get restored instead of only the ones in the filter. Therefore msbuild has numerous prebuilts coming from various projects that are intended to be excluded from source-build.

source-build msbuild binlog

Related to dotnet/source-build#2626

[MichaelSimons]

cc: @rainersigwald

[rainersigwald]

@Forgind can you investigate this? Is it a bug with the solution filter itself, or with NuGet's handling?

[rainersigwald]

@MichaelSimons I'd be fine disabling that for sourcebuild scenarios while we figure it out. We're using it primarily for dogfooding/finding this kind of issue; it's not critical for perf for our repo.

[MichaelSimons]

I'd be fine disabling that for sourcebuild scenarios while we figure it out.

Thanks, I'll get a PR created to disabled this for source-build.

[Forgind]

Just to simplify the repro a bit, these seems to be true with any graph build—you can build a slnf fine, but it really just builds the whole solution.