-
Notifications
You must be signed in to change notification settings - Fork 1.4k
double dash validation fix #6930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Want to start up a Discussion thread about what's going wrong for you? |
I'm running VS2022 and the second execution of There are a lot of orphaned processes: and I have to kill them all for testing to work again. I'll use the github CI for tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you also tested this with your case? Maybe change your test to use --maxcupcount:8 instead of --p:c=d?
Indeed, I tested with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! LGTM, thanks!
Fixes #6689
Context
Validation was failing during the parameter name extraction because of an off-by-1 offset & length.
The original code was hard-coded for a 1-char switch indicator.
Changes Made
Code handles both 1 and 2 character(s) switch indicators.
Testing
ExtractSwitchParameters
+GatherCommandLineSwitches
Notes