Add missing match on metadata location translation #6972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgind
approved these changes
Oct 25, 2021
|
Note: Merge, not squash |
rainersigwald
approved these changes
Oct 25, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Project cache usage forces all projects to be evaluated on the main node. When a project gets a cache miss, it gets built. When that build gets scheduled on an out of proc node, the project instance gets serialized to that node. Some recent change in msbuild turns on full project instance translation, and a bug in item element translation (incomplete translation) makes the task builder crash with a null pointer for metadata location.
This could also crash for all other VS scenarios that end up triggering full project instance translation.
Changes Made
Added missing translation of match on metadata attribute locations
Testing
Updated incomplete unit test