Skip to content

SA1010 Opening square brackets should not be preceded by a space #7205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2022
Merged

SA1010 Opening square brackets should not be preceded by a space #7205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f4efa77
SA1010 Opening square brackets should not be preceded by a space
elachlan Jan 2, 2022
3f9076c
revert changes to deprecated
elachlan Jan 3, 2022
5d78c43
Merge branch 'master' into SA1010
elachlan Jan 8, 2022
dcb05a5
enable warning on SA1010
elachlan Jan 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ dotnet_diagnostic.SA1008.severity = suggestion
dotnet_diagnostic.SA1009.severity = suggestion

# Opening square brackets should not be preceded by a space
dotnet_diagnostic.SA1010.severity = suggestion
dotnet_diagnostic.SA1010.severity = warning

# Closing square bracket should be followed by a space
dotnet_diagnostic.SA1011.severity = suggestion
Expand Down
2 changes: 1 addition & 1 deletion src/Build/BackEnd/Components/Communications/NodeProviderOutOfProcBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,7 +1057,7 @@ private bool ProcessBodyBytesRead(int bytesRead, int packetLength, NodePacketTyp
return true;
}

private bool ReadAndRoutePacket(NodePacketType packetType, byte [] packetData, int packetLength)
private bool ReadAndRoutePacket(NodePacketType packetType, byte[] packetData, int packetLength)
{
try
{
Expand Down
6 changes: 3 additions & 3 deletions src/MSBuild/XMake.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ private static void HandleConfigurationException(Exception ex)
[MTAThread]
public static int Main(
#if !FEATURE_GET_COMMANDLINE
string [] args
string[] args
#endif
)
{
Expand Down Expand Up @@ -482,7 +482,7 @@ public static ExitType Execute(
#if FEATURE_GET_COMMANDLINE
string commandLine
#else
string [] commandLine
string[] commandLine
#endif
)
{
Expand Down Expand Up @@ -1615,7 +1615,7 @@ private static void GatherAllSwitches(
#if FEATURE_GET_COMMANDLINE
string commandLine,
#else
string [] commandLine,
string[] commandLine,
#endif
out CommandLineSwitches switchesFromAutoResponseFile, out CommandLineSwitches switchesNotFromAutoResponseFile)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Tasks/CombineXmlElements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class CombineXmlElements : TaskExtension
/// <summary>
/// The XML elements to include as children of the root element
/// </summary>
public ITaskItem [] XmlElements { get; set; }
public ITaskItem[] XmlElements { get; set; }

/// <summary>
/// The generated XML
Expand Down