Skip to content

SA1102 Query clause should follow previous clause #7261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022
Merged

SA1102 Query clause should follow previous clause #7261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ dotnet_diagnostic.SA1100.severity = suggestion

dotnet_diagnostic.SA1101.severity = none

dotnet_diagnostic.SA1102.severity = suggestion
dotnet_diagnostic.SA1102.severity = warning

# Code should not contain empty statements
dotnet_diagnostic.SA1106.severity = suggestion
Expand Down
1 change: 0 additions & 1 deletion src/Shared/AssemblyFolders/AssemblyFoldersFromConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ private static List<AssemblyFolderItem> GatherVersionStrings(string targetRuntim
(from folder in collection.AssemblyFolders
let targetVersion = VersionUtilities.ConvertToVersion(targetRuntimeVersion)
let replacementVersion = GetFrameworkVersion(folder.FrameworkVersion)

where targetVersion != null && targetVersion >= replacementVersion
orderby folder.FrameworkVersion descending
select folder).ToList();
Expand Down