Fix import of x86 COM Component in ClickOnce Publish #7328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
added
Area: ClickOnce
John-Hart
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
https://developercommunity.visualstudio.com/t/MSB3179:-Problem-isolating-COM-reference/1571958
Customer Impact
Customer projects that reference a x86 COM binary cannot publish their project using ClickOnce provider.
Regression?
Yes (Dev16 -> Dev17)
Summary
ClickOnce's msbuild task to generate the application manifest has code that imports COM Component by reading their registration data from the registry. In this scenario, the COM reference is an x86 binary that is registered under HKCR\WOW6432Node\Clsid node. In dev17 with msbuild being an x64 process, the code is not reading from the WOW6432Node.
The fix is to update the code that's reads COM registration data to look under the WOW6432 node of HKCR as well.
Testing
Verifed with customer provided repro project that x86 COM component is imported fine after the fix.
CTI team has run regression tests and signed off on the private.
Risk
Low. The check to read from the WOW6432 node is a fallback when we cannot get registration info from the non-WOW location.