Make DeepCopyFrom (for ProjectElementContainers) copy all descendants instead of just the direct children #7454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainersigwald
approved these changes
Mar 10, 2022
Forgind
added
the
merge-when-branch-open
Forgind
changed the title
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Apr 29, 2022
…ts (dotnet#7454)" This reverts commit e39a9be. Fixes a regression caused by the fix, tracked as https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1526076.
Forgind
added a commit
that referenced
this pull request
May 2, 2022
Revert #7454 to fix double-DeepCopy regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7435
Context
When "DeepCopy"ing ProjectItemGroupElements, we copied attributes but not children, which meant we would lose them if present.
Changes Made
Recursively copy children as well.
Testing
Ran (and passed) rainersigwald's unit test.