Skip to content

Conversation

@rainersigwald
Copy link
Member

This failed for me in an unrelated PR and on my dev box and at least on my dev box it was because sometimes my PowerShell profile took longer than 1 second to process.

Pass -NoProfile to avoid that time entirely when it's not necessary.

In addition, save the engine's log to the test log to give some clues if the test fails again.

This failed for me in an unrelated PR and on my dev box and
at least on my dev box it was because sometimes my PowerShell
profile took longer than 1 second to process.

Pass -NoProfile to avoid that time entirely when it's not necessary.

In addition, save the engine's log to the test log to give some clues
if the test fails again.
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward.
It would be nice if there was a way to call BCL function through dotnet CLI, so that we wouldn't need to rely on shells here (or author one-off binary)

@rainersigwald rainersigwald added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Apr 17, 2023
@JanKrivanek
Copy link
Member

@JaynieBai JaynieBai merged commit 684efac into dotnet:main Apr 23, 2023
@JanKrivanek
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants