Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented Aug 4, 2023

Contributes to dotnet/source-build#3551

Sourcelink dependency isn't needed anymore. Arcade uses sourcelink tooling that is included in .NET SDK 8.0 preview 6.

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team and rainersigwald August 4, 2023 18:43
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. I saw this when bumping something and forgot to ask about it :)

@NikolaMilosavljevic
Copy link
Member Author

cc @MichaelSimons, @mmitche - we need one more reviewer

@rainersigwald rainersigwald merged commit 92ac641 into dotnet:main Aug 4, 2023
@ViktorHofer
Copy link
Member

@NikolaMilosavljevic do you have a list of repositories that still need to be updated? I assume that all repositories in the VMR need the sourcelink entry removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants