-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix dotnet path for RoslynCodeTaskFactory #9207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24f6f92
to
035d8ed
Compare
035d8ed
to
63edbe4
Compare
src/Tasks/RoslynCodeTaskFactory/RoslynCodeTaskFactoryCompilers.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of nits, but looks good!
src/Tasks/RoslynCodeTaskFactory/RoslynCodeTaskFactoryCompilers.cs
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
YuliiaKovalova
approved these changes
Sep 26, 2023
rainersigwald
approved these changes
Oct 26, 2023
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9052
Context
For RoslynCodeTaskFactory, dotnet path is wrongly set using the path of the application when running the application via application.exe.
Changes Made
Get dotnet path through the following in order.
Testing
Add a test that verifies build the task of RoslynCodeTaskFactory using API.
Notes