Skip to content

Enable SDL (PoliCheck, Credscan) in official builds #9239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Enable SDL (PoliCheck, Credscan) in official builds #9239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6eb17c
Enable SDL (PoliCheck, Credscan) in official builds
GangWang01 Sep 15, 2023
0e77858
Add policheck exclusions
GangWang01 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .vsts-dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ variables:
value: true
- name: Codeql.Enabled
value: true
- ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
- group: DotNet-MSBuild-SDLValidation-Params

stages:
- stage: build
Expand Down Expand Up @@ -294,3 +296,17 @@ stages:
enableSymbolValidation: false
enableSourceLinkValidation: false
enableNugetValidation: false
SDLValidationParameters:
enable: true
continueOnError: false
params: ' -SourceToolsList @("policheck","credscan")
-TsaInstanceURL "$(_TsaInstanceURL)"
-TsaProjectName "$(_TsaProjectName)"
-TsaNotificationEmail "$(_TsaNotificationEmail)"
-TsaCodebaseAdmin "$(_TsaCodebaseAdmin)"
-TsaBugAreaPath "$(_TsaBugAreaPath)"
-TsaIterationPath "$(_TsaIterationPath)"
-TsaRepositoryName "dotnet-msbuild"
-TsaCodebaseName "dotnet-msbuild"
-TsaPublish $True
-PoliCheckAdditionalRunConfigParams @("UserExclusionPath < $(Build.SourcesDirectory)\eng\policheck_exclusions.xml")'
13 changes: 13 additions & 0 deletions eng/policheck_exclusions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<PoliCheckExclusions>
<!-- All strings must be UPPER CASE -->
<!--Each of these exclusions is a folder name -if \[name]\exists in the file path, it will be skipped -->
<!--<Exclusion Type="FolderPathFull">ABC|XYZ</Exclusion>-->
<!--Each of these exclusions is a folder name -if any folder or file starts with "\[name]", it will be skipped -->
<!--<Exclusion Type="FolderPathStart">ABC|XYZ</Exclusion>-->
<!--Each of these file types will be completely skipped for the entire scan -->
<!--<Exclusion Type="FileType">.ABC|.XYZ</Exclusion>-->
<!--The specified file names will be skipped during the scan regardless which folder they are in -->
<!--<Exclusion Type="FileName">ABC.TXT|XYZ.CS</Exclusion>-->

<Exclusion Type="FolderPathFull">.DOTNET</Exclusion>
</PoliCheckExclusions>