-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Use distinct signal to wait to cancel the submission #9326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks as a good way to get rid of some of the pesky flakyness - great!
I'd love to see the test to not iterate the log events repetitively. We can use MockLogger to avoid the additional thread/task and 'wake-check-sleep' pattern here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Fixes #9298
Context
Waiting using
Thread.Sleep(500)
in the test is unreliable.Changes Made
Wait until the specified log appears rather than
Thread.Sleep(500)
.Testing
Notes