Fix build and execution for windows/arm64

[kunalspathak]

When building performance for

Currently micro benchmarks fails to build on windows/arm64 because of dotnet/roslyn#42393. As a workaround, we need to pass /p:DebugType=portable to build the micro benchmark project. Also, while running the micro benchmarks on windows/arm64 pass this parameter to build the autogenerated project.

Ref - dotnet/BenchmarkDotNet#1395

[billwert]

I wonder if we should just switch to portable PDBs entirely and not conditionalize this. @noahfalk - can you opine about about "classic" vs "portable" PDBs and how we should think about them?

[kunalspathak]

Yeah, I was not sure about the compatibility with older netcoreapp / net framework versions if given portable. If @noahfalk or someone else can confirm, I will go ahead with that.

[noahfalk]

At this point I think of portable pdb format as a reasonable default for most use cases, and then use the classic format if you need to be back compatible with specific tools that have never added portable pdb support. There is a symbol conversion tool so that you can generate only portable pdb at build time and then later create the classic pdb when/if your use-case requires it. Last I recall .Net Core produces and uploads both formats to symbol server attempting to facilitate the largest number of use-cases. I'm not sure if symbol upload is something you bother with for these benchmark apps though.

There is a doc that describes use cases that are lacking portable pdb support but I believe it is out of date. @tmat usually has the most up-to-date info on support and maybe he could update the doc? Giving it a quick read I think the MSDIA case is now supported, and .Net reflector might be as well?

[kunalspathak]

Alright, I will make the MicroBenchmarks.csproj build with portable symbols unless @billwert or @adamsitnik think otherwise.

[adamsitnik]

Alright, I will make the MicroBenchmarks.csproj build with portable symbols unless @billwert or @adamsitnik think otherwise.

I don't mind switching to portable symbols

[billwert]

Love it. Thanks! Thanks, -Bill

…

________________________________ From: Adam Sitnik <[email protected]> Sent: Monday, March 23, 2020 4:08:40 AM To: dotnet/performance <[email protected]> Cc: Bill Wert <[email protected]>; Mention <[email protected]> Subject: Re: [dotnet/performance] Fix build and execution for windows/arm64 (#1243) Alright, I will make the MicroBenchmarks.csproj build with portable symbols unless @billwert<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbillwert&data=02%7C01%7Cbillwert%40microsoft.com%7C8a4d5a715ce944975e9f08d7cf1a8b3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205585221704711&sdata=YeHD17DM4eRa7t000NIe8BjOK%2FEdrLuzN6EIv%2BqvCN8%3D&reserved=0> or @adamsitnik<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fadamsitnik&data=02%7C01%7Cbillwert%40microsoft.com%7C8a4d5a715ce944975e9f08d7cf1a8b3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205585221714708&sdata=sagLlDaWZ%2BXL3oKFTIU%2BEDObvEpMIWQpxQSiL9yEApg%3D&reserved=0> think otherwise. I don't mind switching to portable symbols — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdotnet%2Fperformance%2Fpull%2F1243%23issuecomment-602527092&data=02%7C01%7Cbillwert%40microsoft.com%7C8a4d5a715ce944975e9f08d7cf1a8b3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205585221724703&sdata=Csrnc3CMUUxOZXMDEufI6MNqv%2BTuphuT2rzwNquPa1A%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABCQI4C3TYO3YDHEBWA35R3RI47LRANCNFSM4LPN2PIA&data=02%7C01%7Cbillwert%40microsoft.com%7C8a4d5a715ce944975e9f08d7cf1a8b3d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637205585221734701&sdata=SIFLVQENthqfojkmkzMzF8uaQN6FusQ6jf6SL%2BdexNQ%3D&reserved=0>.

[adamsitnik]

LGTM, thank you @kunalspathak !