Add benchmarks for Microsoft.Extensions.Configuration.Xml

[amoerie]

Hi

While creating a pull request in the dotnet runtime repo, I created some benchmarks to ensure my changes did not introduce a regression.

By request of @safern, I am adding these benchmarks here.

I'm still struggling a bit with properly running them, and I'm short on time, so please give me a while to get this PR into a more polished state.

[safern]

Looks reasonable. I'd like @adamsitnik to take a look.

[danmoseley]

I just want to say this is beautiful.

[danmoseley]

Ack, this one is really old. @dotnet/area-extensions-configuration could one of you please sign off or review?

reopening to rebuild.

[amoerie]

I completely forgot about this (looks like you guys did too 😁) but I can try to find some time this weekend or next week to tidy it up as I promised almost a year ago.

[maryamariyan]

[adamsitnik]

@amoerie I am terribly sorry, I have missed the GitHub notification. I've pushed a few fixes to your fork based on https://github.com/dotnet/performance/blob/main/docs/microbenchmark-design-guidelines.md

[amoerie]

No worries at all, this is probably super low in the priority list and rightly so.

Thanks for applying those fixes! They make a lot of sense.

I wanted to add a small note about the removal of repeated.xml:
The repeated.xml test file should work with the Microsoft.Extensions.Configuration.Xml package that came with .NET 6. (My PR added support for this, and that was the original context where I created these benchmarks)

So if the dependency on the Microsoft.Extensions.* libraries were updated to their respective 6.* versions, the benchmark should run.

[danmoseley]

Thanks @adamsitnik and @amoerie

@amoerie if you see other benchmark gaps you are interested in contributing to, that would be welcome and you can expect us to merge them more promptly (this is unusual 😄 )

[amoerie]

Thanks @adamsitnik and @amoerie

@amoerie if you see other benchmark gaps you are interested in contributing to, that would be welcome and you can expect us to merge them more promptly (this is unusual 😄 )

I'm not exactly in the habit of perusing the dotnet repositories here, but I'll gladly contribute if I have an itch to scratch and I feel like I'm up to the task. 😅

Thanks for the review support, it is a very good learning resource!

[adamsitnik]

So if the dependency on the Microsoft.Extensions.* libraries were updated to their respective 6.* versions, the benchmark should run.

@amoerie big thanks for explaining why it was failing for me. I've sent PR with the fix: #2248