Skip to content

Conversation

@danmoseley
Copy link
Member

@danmoseley danmoseley commented Feb 4, 2022

What I get on my machine, without dotnet/runtime#64782

Method value Mean Error StdDev Median Min Max Allocated
TryParse true 9.877 ns 0.3212 ns 0.3700 ns 9.807 ns 9.161 ns 10.60 ns -
TryParse false 11.404 ns 0.4224 ns 0.4865 ns 11.344 ns 10.722 ns 12.22 ns -
TryParse fAlSe 11.179 ns 0.2641 ns 0.2936 ns 11.167 ns 10.733 ns 11.84 ns -
TryParse TrUe 12.215 ns 1.7123 ns 1.9032 ns 11.467 ns 10.127 ns 15.41 ns -
TryParse tru 23.106 ns 0.6177 ns 0.6866 ns 22.909 ns 22.116 ns 24.61 ns -
TryParse tRuu 25.520 ns 0.5347 ns 0.5722 ns 25.542 ns 24.739 ns 26.64 ns -
TryParse falss 26.871 ns 0.5399 ns 0.5302 ns 27.117 ns 25.552 ns 27.44 ns -
TryParse bogus 34.17 ns 6.021 ns 6.934 ns 30.54 ns 27.177 ns 48.57 ns -
Parse true 16.222 ns 0.7374 ns 0.8492 ns 16.208 ns 14.751 ns 18.18 ns -
Parse false 17.495 ns 1.1390 ns 1.3117 ns 16.919 ns 16.059 ns 20.40 ns -

@danmoseley
Copy link
Member Author

@DrewScoggins @LoopedBard3 Helix API does not contain an entry for Windows.10.Amd64.ClientRS4.DevEx.15.8.Open

@LoopedBard3
Copy link
Member

Looks like the ClientRS4 queue is EOL and the likely upgrade is to ClientRS5. I will do a test run to see if using the new queue fixes the issue.

@LoopedBard3
Copy link
Member

Testing in PR #2237, will update once the run completes.

@LoopedBard3
Copy link
Member

Closing for rebase since #2237 has been merged.

@LoopedBard3
Copy link
Member

It appears reopening did not catch the latest queue update.

@danmoseley danmoseley closed this Feb 5, 2022
@danmoseley danmoseley reopened this Feb 5, 2022
@danmoseley
Copy link
Member Author

performance-ci (windows RS4 x64 micro_net461 Open LTS) results can be ignored. it's a dead queue

@danmoseley
Copy link
Member Author

@LoopedBard3 perhaps you'd like to review so I can merge?

@danmoseley danmoseley closed this Feb 5, 2022
@danmoseley danmoseley reopened this Feb 5, 2022
@danmoseley
Copy link
Member Author

Now

Method value Mean Error StdDev Median Min Max Allocated
TryParse true 10.252 ns 0.2067 ns 0.1832 ns 10.211 ns 10.011 ns 10.583 ns -
TryParse false 11.393 ns 0.5187 ns 0.5974 ns 11.515 ns 10.246 ns 12.289 ns -
TryParse TRUE 13.440 ns 2.3827 ns 2.7440 ns 12.408 ns 10.431 ns 19.580 ns -
TryParse False 13.902 ns 2.3719 ns 2.6363 ns 12.672 ns 11.074 ns 20.427 ns -
TryParse 0 19.966 ns 0.7141 ns 0.8223 ns 20.130 ns 18.458 ns 21.506 ns -
TryParse Bogus 24.709 ns 2.0741 ns 2.3053 ns 23.893 ns 22.295 ns 29.574 ns -
Parse true 16.790 ns 1.1961 ns 1.3774 ns 16.326 ns 15.212 ns 19.532 ns -
Parse TRUE 18.818 ns 1.4715 ns 1.5745 ns 18.369 ns 16.956 ns 22.533 ns -
Parse false 19.133 ns 0.7491 ns 0.8016 ns 19.191 ns 17.416 ns 21.096 ns -
Parse False 19.211 ns 1.8161 ns 2.0915 ns 19.938 ns 15.663 ns 22.658 ns -
ToString True 2.225 ns 0.2246 ns 0.2206 ns 2.210 ns 1.849 ns 2.786 ns -
ToString False 3.220 ns 0.2709 ns 0.3119 ns 3.219 ns 2.742 ns 3.886 ns -

@danmoseley danmoseley closed this Feb 5, 2022
@danmoseley danmoseley reopened this Feb 5, 2022
@danmoseley danmoseley merged commit c40d303 into dotnet:main Feb 6, 2022
@danmoseley danmoseley deleted the bool.parse branch February 6, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants