[VS Code] Fix project.razor.json serialization issue #8489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzngard
approved these changes
Mar 22, 2023
Contributor
ryzngard
left a comment
ryzngard
left a comment
There was a problem hiding this comment.
As with most things, would love some sort of test for this :)
| using (var writer = tempFileInfo.CreateText()) | ||
| { | ||
| _serializer.Serialize(writer, projectSnapshot); | ||
| var projectRazorJson = new ProjectRazorJson(publishFilePath, projectSnapshot.InternalProjectSnapshot); |
Contributor
There was a problem hiding this comment.
❓is there ever a time when serializing the snapshot is correct?
Contributor
Author
There was a problem hiding this comment.
It results in a circular dependency, so I don't think so (or at least not any scenario I can think of)
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Properties/AssemblyInfo.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.AspNetCore.Razor.OmniSharpPlugin/DefaultProjectChangePublisher.cs
Outdated
Show resolved
Hide resolved
|
|
||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly: InternalsVisibleTo("Microsoft.AspNetCore.Razor.OmniSharpPlugin, PublicKey=0024000004800000940000000602000000240000525341310004000001000100f33a29044fa9d740c9b3213a93e57c84b472c84e0b8a0e1ae48e67a9f8f6de9d5f7f3d52ac23e48ac51801f1dc950abe901da34d2a9e3baadb141a17c77ef3c565dd5ee5054b91cf63bb3c6ab83f72ab3aafe93d0fc3c2348b764fafb0b1c0733de51459aeab46580384bf9d74c4e28164b7cde247f891ba07891c9d872ad2bb")] |
Member
There was a problem hiding this comment.
This should go too. Anything OmniSharpPlugin needs from this project can just be public in this project
Contributor
Author
|
Thanks for the reviews and feedback Andrew and David! @davidwengier could I get another look at this? |
davidwengier
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
project.razor.jsonfiles because we were trying to serialize the project snapshot when we should have been serializing theProjectRazorJsontype. We used to do this correctly but it seems this behavior was somehow changed in External access #8046 (Ryan's parting gift to us 😄 )