add ObjectPool to Version.Details #8763
Conversation
| </Dependency> | ||
| <!-- Necessary for source-build. This allows the package to be retrieved from previously-source-built artifacts | ||
| and flow in as dependencies of the packages produced by razor. --> | ||
| <Dependency Name="Microsoft.Extensions.ObjectPool" Version="6.0.0"> |
There was a problem hiding this comment.
Can this be a live version? I am surprised the repo source-build legs don't encounter the same issue as the product build in that it is trying to load the reference package.
There was a problem hiding this comment.
I'm guessing since it only packages the DLL in the intermediate and does not actually load it in, similar to what Arcade did with CodeAnalysis.CSharp and DependencyModel (with the issue with these ref packs only surfacing in its consumer - runtime)
There was a problem hiding this comment.
Right, I understand that part.
I think I just answered my question in that the smoke-tests are what caught this. We don't have anything that is running tests against the intermediate packages.
There was a problem hiding this comment.
Ideally this would be a live version in order to eliminate potential differences in the product source-build versus the source-build repo leg.
There was a problem hiding this comment.
Not sure that is possible with the tooling repos since they potentially go into multiple releases...IDK
|
@dotnet/razor-tooling soft ping, would be great if we could have someone review this small PR, thank you! |
|
@davidwengier thank you for the review! Could you also please merge the PR? I unfortunately do not have write permissions to the repo so can't do it myself. Thanks! |
3 participants
Summary of the changes
Contributes to dotnet/source-build#3043
Declaring the
Microsoft.Extensions.ObjectPooldependency inVersion.Details.xmlwill allow source-build to replace the currently used6.0.0version with then-1version coming from previously source-built artifacts in the product / VMR build.Without this change, once repo PvP is enabled for
razor, a ref pack ofMicrosoft.Extensions.ObjectPoolwould be used instead of a live version, causing a build break for projects that want to utilize the package for source generation. Example of such failure - https://dev.azure.com/dnceng-public/public/_build/results?buildId=284887&view=results