Task queue refactoring #42610
Merged
Task queue refactoring #42610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Workspaces/Core/Portable/Workspace/Host/TaskScheduler/IWorkspaceTaskScheduler.cs
Outdated
Show resolved
Hide resolved
Member
|
oVerall, very pro on this change :) |
tmat
force-pushed
the
TaskQueueRefactoring
branch
from
95253dc to
9d1e5bc
Compare
src/EditorFeatures/TestUtilities/Workspaces/TestForegroundNotificationService.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/TaskList/ExternalErrorDiagnosticUpdateSource.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/Core/Def/Implementation/Workspace/VisualStudioTaskSchedulerProvider.cs
Outdated
Show resolved
Hide resolved
...ore/Portable/Workspace/Host/TaskScheduler/IWorkspaceAsynchronousOperationListenerProvider.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Host/TaskScheduler/TaskSchedulerProvider.cs
Outdated
Show resolved
Hide resolved
...Core/Portable/Workspace/Host/TaskScheduler/WorkspaceAsynchronousOperationListenerProvider.cs
Outdated
Show resolved
Hide resolved
src/Workspaces/Core/Portable/Workspace/Host/TaskScheduler/ITaskSchedulerProvider.cs
Outdated
Show resolved
Hide resolved
Member
|
As before, i'm 100% positive on this change. It' awesome. I do have:
If we can get that, merge asap :) |
tmat
force-pushed
the
TaskQueueRefactoring
branch
from
2f34572 to
2485e4e
Compare
CyrusNajmabadi
approved these changes
Mar 24, 2020
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Mar 26, 2020
* upstream/master: (697 commits) Update comment for clarity More solution API tests (dotnet#42451) Task queue refactoring (dotnet#42610) Add string ctor to MemberNotNull/When (dotnet#42712) Use the same block structure for code and Metadata As Source Add work items When generating abstract members, generate them as protected, not internal Avoid operations on disposed workspace (dotnet#42768) Remove duplicate validation logic Speed up regex comment detector pattern. Stop walking up once we hit a statement Speed up regex comment detector pattern. Strengthen the condition in which nodes are determined to be in the same block Remove the SolutionPopulator incremental analyzer. Update Visualizer version again to fix bug, actually use invariant culture. Formatting: force a space after attribute on parameter (dotnet#42466) Add test for different case VB Update src/EditorFeatures/VisualBasicTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.vb Update src/EditorFeatures/CSharpTest/CodeActions/ReplaceMethodWithProperty/ReplaceMethodWithPropertyTests.cs GenerateUniqueName for ReplaceMethodWithProperty ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate functionality, separate concerns, simplify.