Skip to content

Extensions: adjust specialname rules #78215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

Extensions: adjust specialname rules #78215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce6fd8b
Extensions: adjust specialname rules
jcouv Apr 19, 2025
f8555ca
Address feedback
jcouv Apr 22, 2025
747d495
Merge remote-tracking branch 'dotnet/main' into extensions-special
jcouv Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Compilers/CSharp/Portable/Symbols/Extensions/SourceExtensionImplementationMethodSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public SourceExtensionImplementationMethodSymbol(MethodSymbol sourceMethod)
public override MethodKind MethodKind => MethodKind.Ordinary;
public override bool IsImplicitlyDeclared => true;

internal override bool HasSpecialName => true; // Tracked by https://github.com/dotnet/roslyn/issues/76130 : reconcile with spec
internal override bool HasSpecialName => false;

internal override int ParameterCount
{
Expand Down
2 changes: 1 addition & 1 deletion src/Compilers/CSharp/Portable/Symbols/Extensions/SynthesizedExtensionMarker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ internal SynthesizedExtensionMarker(SourceMemberContainerTypeSymbol extensionTyp

private static DeclarationModifiers GetDeclarationModifiers() => DeclarationModifiers.Private | DeclarationModifiers.Static;

internal override bool HasSpecialName => true; // Tracked by https://github.com/dotnet/roslyn/issues/76130 : reconcile with spec
internal override bool HasSpecialName => true;

internal override void GenerateMethodBody(TypeCompilationState compilationState, BindingDiagnosticBag diagnostics)
{
Expand Down
4 changes: 2 additions & 2 deletions src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PENamedTypeSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@ internal sealed override ParameterSymbol? ExtensionParameter
methodSymbol.IsGenericMethod ||
!methodSymbol.IsStatic ||
!methodSymbol.ReturnsVoid ||
methodSymbol.ParameterCount != 1) // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Should we accept more than one parameter (in case new versions add more info)?
methodSymbol.ParameterCount != 1)
{
return null; // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Test this code path
}
Expand Down Expand Up @@ -467,7 +467,7 @@ static MethodSymbol getMarkerMethodSymbol(PENamedTypeSymbol @this, ExtensionInfo

foreach (var member in @this.ContainingType.GetMembers(method.Name))
{
if (member is not MethodSymbol { HasSpecialName: true, IsStatic: true } candidate)
if (member is not MethodSymbol { IsStatic: true } candidate)
{
continue; // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Test this code path
}
Expand Down
Loading