Merge 'main' into UserDefinedCompoundAssignment

.vscode/launch.json

@@ -62,6 +62,51 @@
       "stopAtEntry": false,
       "console": "internalConsole"
     },
+    {
+      "name": "Launch Microsoft.Build.Tasks.CodeAnalysis.dll via MSBuild.exe (netfx)",
+      "type": "clr",
+      "request": "launch",
+      "preLaunchTask": "build toolset",
+      "program": "C:/Program Files/Microsoft Visual Studio/2022/Preview/MSBuild/Current/Bin/amd64/MSBuild.exe",
+      "args": [
+        "-restore",
+        "-p:RoslynTargetsPath=${workspaceFolder}/artifacts/bin/Microsoft.Net.Compilers.Toolset.Package/Debug/tasks/net472",
+      ],
+      // A simple project that can be used to debug the build tasks against.
+      "cwd": "${workspaceFolder}/src/Tools/Source/CompilerGeneratorTools/Source/BoundTreeGenerator",
+      "stopAtEntry": false,
+      "console": "internalConsole"
+    },
+    {
+      "name": "Launch Microsoft.Build.Tasks.CodeAnalysis.dll via MSBuild.exe (netcore)",
+      "type": "clr",
+      "request": "launch",
+      "preLaunchTask": "build toolset",
+      "program": "C:/Program Files/Microsoft Visual Studio/2022/Preview/MSBuild/Current/Bin/amd64/MSBuild.exe",
+      "args": [
+        "-restore",
+        "-p:RoslynTargetsPath=${workspaceFolder}/artifacts/bin/Microsoft.Net.Compilers.Toolset.Package/Debug/tasks/netcore",
+      ],
+      // A simple project that can be used to debug the build tasks against.
+      "cwd": "${workspaceFolder}/src/Tools/Source/CompilerGeneratorTools/Source/BoundTreeGenerator",
+      "stopAtEntry": false,
+      "console": "internalConsole"
+    },
+    {
+      "name": "Launch Microsoft.Build.Tasks.CodeAnalysis.dll via dotnet build",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "build toolset",
+      "program": "dotnet",
+      "args": [
+        "build",
+        "-p:RoslynTargetsPath=${workspaceFolder}/artifacts/bin/Microsoft.Net.Compilers.Toolset.Package/Debug/tasks/netcore",
+      ],
+      // A simple project that can be used to debug the build tasks against.
+      "cwd": "${workspaceFolder}/src/Tools/Source/CompilerGeneratorTools/Source/BoundTreeGenerator",
+      "stopAtEntry": false,
+      "console": "internalConsole"
+    },
     {
       "name": ".NET Core Launch (console)",
       "type": "coreclr",

.vscode/tasks.json

@@ -97,6 +97,18 @@
         "problemMatcher": "$msCompile",
         "group": "build"
     },
+    {
+        "label": "build toolset",
+        "type": "shell",
+        "command": "dotnet",
+        "args": [
+          "build",
+          "-p:GenerateFullPaths=true",
+          "${workspaceFolder}/src/NuGet/Microsoft.Net.Compilers.Toolset/AnyCpu/Microsoft.Net.Compilers.Toolset.Package.csproj"
+        ],
+        "problemMatcher": "$msCompile",
+        "group": "build"
+    },
     {
         "label": "msbuild current project",
         "type": "shell",

azure-pipelines-official.yml

@@ -44,6 +44,12 @@ parameters:
   type: boolean
   default: true
 
+# An optional VS commit SHA that will be automatically cherry-picked
+# to the insertion PR created by this build.
+- name: VisualStudioCherryPickSHA
+  type: string
+  default: '(default)'
+
 schedules:
   - cron: "0 8 23-29 * 0"
     displayName: "Monthly smoke test"
@@ -394,6 +400,7 @@ extends:
             publishDataURI: "https://dev.azure.com/dnceng/internal/_apis/git/repositories/dotnet-roslyn/items?path=eng/config/PublishData.json&api-version=6.0"
             publishDataAccessToken: "$(System.AccessToken)"
             dropPath: '$(Pipeline.Workspace)\VSSetup'
+            cherryPick: ${{ parameters.VisualStudioCherryPickSHA }}
 
     - ${{ if and(ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}:
       - template: /eng/common/templates-official/post-build/post-build.yml@self

azure-pipelines-pr-validation.yml

@@ -22,6 +22,9 @@ parameters:
 - name: OptionalTitlePrefix
   type: string
   default: '[PR Validation]'
+- name: VisualStudioCherryPickSHA
+  type: string
+  default: '(default)'
 - name: InsertToolset
   type: boolean
   default: true
@@ -323,6 +326,7 @@ extends:
             queueSpeedometerValidation: true
             dropPath: '$(Pipeline.Workspace)\VSSetup'
             retainInsertedBuild: false
+            cherryPick: ${{ parameters.VisualStudioCherryPickSHA }}
         # Arcade is done so we can set BuildNumber back
         - powershell: Write-Host "##vso[build.updatebuildnumber]$(FancyBuildNumber)"
           displayName: Reset BuildNumber

eng/Version.Details.xml

@@ -13,19 +13,19 @@
       <SourceBuild RepoName="source-build-externals" ManagedOnly="true" />
     </Dependency>
     <!-- Intermediate is necessary for source build. -->
-    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="10.0.620702">
+    <Dependency Name="Microsoft.SourceBuild.Intermediate.source-build-reference-packages" Version="10.0.621601">
       <Uri>https://github.com/dotnet/source-build-reference-packages</Uri>
-      <Sha>8a21184a27103ca3e365b21553e32f2a1c0661d3</Sha>
+      <Sha>4b566314cf9602b77f25538a88b9c8175231c106</Sha>
       <SourceBuild RepoName="source-build-reference-packages" ManagedOnly="true" />
     </Dependency>
-    <Dependency Name="System.CommandLine" Version="2.0.0-beta4.24528.1">
+    <Dependency Name="System.CommandLine" Version="2.0.0-beta5.25210.1">
       <Uri>https://github.com/dotnet/command-line-api</Uri>
-      <Sha>feb61c7f328a2401d74f4317b39d02126cfdfe24</Sha>
+      <Sha>e9b0511d7f1128e2bc3be7a658a2a4ea977e602d</Sha>
     </Dependency>
     <!-- Intermediate is necessary for source build. -->
-    <Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.552801">
+    <Dependency Name="Microsoft.SourceBuild.Intermediate.command-line-api" Version="0.1.621001">
       <Uri>https://github.com/dotnet/command-line-api</Uri>
-      <Sha>feb61c7f328a2401d74f4317b39d02126cfdfe24</Sha>
+      <Sha>e9b0511d7f1128e2bc3be7a658a2a4ea977e602d</Sha>
       <SourceBuild RepoName="command-line-api" ManagedOnly="true" />
     </Dependency>
     <!-- Necessary for source-build. This allows the live version of the package to be used by source-build. -->

eng/Versions.props

@@ -48,7 +48,7 @@
     Versions managed by Arcade (see Versions.Details.xml)
   -->
   <PropertyGroup>
-    <SystemCommandLineVersion>2.0.0-beta4.24528.1</SystemCommandLineVersion>
+    <SystemCommandLineVersion>2.0.0-beta5.25210.1</SystemCommandLineVersion>
     <SystemCompositionVersion>9.0.0</SystemCompositionVersion>
     <SystemConfigurationConfigurationManagerVersion>9.0.0</SystemConfigurationConfigurationManagerVersion>
     <SystemDiagnosticsEventLogVersion>9.0.0</SystemDiagnosticsEventLogVersion>

eng/config/PublishData.json

@@ -95,6 +95,7 @@
       "Microsoft.VisualStudio.LanguageServices.LiveShare": "vs-impl",
       "Microsoft.VisualStudio.LanguageServices.Razor.RemoteClient": "vs-impl",
       "Microsoft.VisualStudio.LanguageServices.ExternalAccess.Copilot": "vs-impl",
+      "Microsoft.VisualStudio.LanguageServices.Xaml": "vs-impl",
       "Microsoft.CommonLanguageServerProtocol.Framework": "vs-impl",
       "Microsoft.CommonLanguageServerProtocol.Framework.Binary": "vs-impl",
       "Microsoft.CodeAnalysis.Analyzers": "arcade",
@@ -170,7 +171,7 @@
         "NonShipping"
       ],
       "vsBranch": "rel/d17.14",
-      "insertionTitlePrefix": "[d17.14 P3]",
+      "insertionTitlePrefix": "[d17.14]",
       "insertionCreateDraftPR": false
     },
     "main": {

eng/pipelines/insert.yml

@@ -50,6 +50,9 @@ parameters:
     type: string
     default: ''
 
+  - name: cherryPick
+    type: string
+
 steps:
   - checkout: none
 
@@ -183,7 +186,7 @@ steps:
       .\RIT\tools\net472\OneOffInsertion.ps1 `
         -autoComplete "$(Template.AutoComplete)" `
         -buildQueueName "$(Build.DefinitionName)" `
-        -cherryPick "(default)" `
+        -cherryPick "${{ parameters.cherryPick }}" `
         -userName "$(Template.BuildUserName)" `
         -password "$(Template.BuildPassword)" `
         -componentUserName "$(Template.ComponentUserName)" `

src/Analyzers/CSharp/Tests/RemoveUnusedMembers/RemoveUnusedMembersTests.cs

@@ -3530,4 +3530,33 @@ public unsafe void ToUnmanaged()
             ReferenceAssemblies = ReferenceAssemblies.Net.Net90,
         }.RunAsync();
     }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/77251")]
+    public async Task TestRefFieldWrittenNotRead()
+    {
+        await new VerifyCS.Test
+        {
+            TestCode = """
+                public readonly ref struct RefScope<T>
+                {
+                    public RefScope(ref T originalvalue, T newvalue)
+                    {
+                        _OriginalValue = originalvalue;
+                        _Reference = ref originalvalue;
+                        originalvalue = newvalue;
+                    }
+
+                    readonly ref T _Reference; // Should get no diagnostic here.
+                    readonly T _OriginalValue;
+
+                    public void Dispose()
+                    {
+                        _Reference = _OriginalValue;
+                    }
+                }
+                """,
+            LanguageVersion = LanguageVersion.CSharp13,
+            ReferenceAssemblies = ReferenceAssemblies.Net.Net90,
+        }.RunAsync();
+    }
 }

src/Analyzers/CSharp/Tests/UseAutoProperty/UseAutoPropertyTests.cs

@@ -3134,4 +3134,52 @@ int P
             }
             """);
     }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/78225")]
+    public async Task TestRefProperty1()
+    {
+        await TestMissingInRegularAndScriptAsync(
+            """
+            class Class
+            {
+                [|int i|];
+
+                ref int P
+                {
+                    get
+                    {
+                        return ref i;
+                    }
+                }
+            }
+            """);
+    }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/78225")]
+    public async Task TestRefProperty2()
+    {
+        await TestMissingInRegularAndScriptAsync(
+            """
+            class Class
+            {
+                [|int i|];
+
+                ref int P => ref i;
+            }
+            """);
+    }
+
+    [Fact, WorkItem("https://github.com/dotnet/roslyn/issues/78225")]
+    public async Task TestRefProperty3()
+    {
+        await TestMissingInRegularAndScriptAsync(
+            """
+            class Class
+            {
+                [|int i|];
+
+                readonly ref int P => ref i;
+            }
+            """);
+    }
 }

src/Analyzers/Core/Analyzers/DiagnosticCustomTags.cs

@@ -2,6 +2,7 @@
 // The .NET Foundation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+using System;
 using System.Collections.Immutable;
 using System.Diagnostics;
 using Microsoft.CodeAnalysis.CodeStyle;
@@ -64,7 +65,7 @@ public static string[] UnnecessaryAndNotConfigurable
     }
 
     [Conditional("DEBUG")]
-    private static void Assert(string[] customTags, params string[] tags)
+    private static void Assert(string[] customTags, params ReadOnlySpan<string> tags)
     {
         Debug.Assert(customTags.Length == tags.Length);
 

src/Analyzers/Core/Analyzers/Helpers/DiagnosticHelper.cs

@@ -343,7 +343,7 @@ public sealed class LocalizableStringWithArguments : LocalizableString
         private readonly LocalizableString _messageFormat;
         private readonly string[] _formatArguments;
 
-        public LocalizableStringWithArguments(LocalizableString messageFormat, params object[] formatArguments)
+        public LocalizableStringWithArguments(LocalizableString messageFormat, params ReadOnlySpan<object> formatArguments)
         {
             if (messageFormat == null)
             {
@@ -358,9 +358,7 @@ public LocalizableStringWithArguments(LocalizableString messageFormat, params ob
             _messageFormat = messageFormat;
             _formatArguments = new string[formatArguments.Length];
             for (var i = 0; i < formatArguments.Length; i++)
-            {
                 _formatArguments[i] = $"{formatArguments[i]}";
-            }
         }
 
         protected override string GetText(IFormatProvider? formatProvider)

src/Analyzers/Core/Analyzers/RemoveUnusedMembers/AbstractRemoveUnusedMembersDiagnosticAnalyzer.cs

@@ -583,8 +583,16 @@ private void OnSymbolEnd(SymbolAnalysisContext symbolEndContext, bool hasUnsuppo
                             continue;
 
                         // Do not flag ref-fields that are not read.  A ref-field can exist to have side effects by
-                        // writing into some other location when a write happens to it.
-                        if (member is IFieldSymbol { IsReadOnly: false, RefKind: RefKind.Ref })
+                        // writing into some other location when a write happens to it.  Note: this includes `readonly
+                        // ref` fields as well.  It's still legal to assign a normal value into a `readonly ref` field.
+                        // It's just not allowed to overwrite it *with another ref*.  In other words:
+                        //
+                        //      _readonlyRefField = value;     // is fine.
+                        //      _readonlyRefField = ref value; // is not.
+                        //
+                        // So as long as it is a ref-field, we don't care if it is unread, but is written to.  We must
+                        // continue allowing it.
+                        if (member is IFieldSymbol { RefKind: RefKind.Ref })
                             continue;
                     }
 

src/Analyzers/Core/Analyzers/UseAutoProperty/AbstractUseAutoPropertyAnalyzer.cs

@@ -364,6 +364,9 @@ private void AnalyzePropertyDeclaration(
         if (property.GetMethod == null)
             return;
 
+        if (property.RefKind != RefKind.None)
+            return;
+
         if (!CanExplicitInterfaceImplementationsBeFixed && property.ExplicitInterfaceImplementations.Length != 0)
             return;