Skip to content

Conversation

@davidwengier
Copy link
Member

#78122 broke Razor tests, because we now have to initialize the export provider builder first.
Initializing the export provider builder broke Razor tests, because I had an old copy of the EA dll laying around
Fixing the name of the EA dll broke Razor tests, because of a MEF composition error with the RazorTestLanguageServerFactory
And thats how we got here.

@davidwengier davidwengier requested a review from a team as a code owner April 24, 2025 00:25
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 24, 2025
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@davidwengier davidwengier merged commit 61db35f into dotnet:main Apr 24, 2025
24 of 25 checks passed
@davidwengier davidwengier deleted the FixMEFForRazor branch April 24, 2025 02:03
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 24, 2025
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants