Use built-in inline array types when possible #80557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of synthesizing inline array types, we want to use the ones from the framework when possible (in .NET 10). Contributes to dotnet#74538.
333fred
commented
Oct 3, 2025
| <NetVSShared>net8.0</NetVSShared> | ||
| <NetRoslynBuildHostNetCoreVersion>net6.0</NetRoslynBuildHostNetCoreVersion> | ||
| <NetRoslynNext>net9.0</NetRoslynNext> | ||
| <NetRoslynNext>net10.0</NetRoslynNext> |
There was a problem hiding this comment.
The only projects using this value are now the Emit3 unit tests, and BuildBoss.
jjonescz
approved these changes
Oct 6, 2025
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
jjonescz
reviewed
Oct 6, 2025
jjonescz
approved these changes
Oct 7, 2025
|
@dotnet/roslyn-compiler for a second review |
AlekseyTs
reviewed
Oct 8, 2025
AlekseyTs
reviewed
Oct 8, 2025
AlekseyTs
reviewed
Oct 8, 2025
|
Done with review pass (commit 4) #Closed |
|
@AlekseyTs for another review pass |
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
AlekseyTs
reviewed
Oct 9, 2025
|
Done with review pass (commit 5) #Closed |
jcouv
added
the
Code Gen Quality
|
@333fred It looks like there are legitimate test failures #Closed |
333fred
commented
Oct 15, 2025
src/Compilers/CSharp/Test/Emit3/Semantics/CollectionExpressionTests.cs
Outdated
Show resolved
Hide resolved
|
PEVerify gets me every time. @AlekseyTs, should be resolved. |
AlekseyTs
approved these changes
Oct 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
|
@jjonescz for another look |
jjonescz
reviewed
Oct 18, 2025
jjonescz
approved these changes
Oct 21, 2025
* upstream/main: (123 commits) Fix SafeContext of Span-valued collection expressions to match specification (dotnet#80684) Improve detection of invalid references for implicitly typed expression variables declared within implicit object creation expressions. (dotnet#80546) Add test demonstrating behavior of ToMinimalDisplayString. (dotnet#80757) Only set DOTNET_HOST_PATH if something was installed (dotnet#80842) Clean up a Razor external access service (dotnet#80830) Remove unused statement (dotnet#80823) Allow foreach on typed null enumerables (dotnet#80783) Update documentation for DeclaringSyntaxReferences and Locations to clarify partial members behavior (dotnet#80704) Fix issue converting an auto prop to a full prop when 'field' and 'initializers' are involved Rename childIsSimple to innerExpressionHasPrimaryPrecedence and add more test cases Remove placeholder WorkItem attributes from new tests Fix RemoveUnnecessaryParentheses to detect simple expressions in bitwise operations [main] Update dependencies from dotnet/arcade (dotnet#80828) Fix ITypeSymbol.BaseType documentation for type parameters (dotnet#80770) soft-select select camelcase matched item if user might be typing an undefined type parameter (dotnet#80809) Allow semantic tokens in Razor to be better behaved (dotnet#80815) Rebase Remove using Update test Add fix all test ...
This was referenced Oct 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of synthesizing inline array types, we want to use the ones from the framework when possible (in .NET 10). Contributes to #74538.