Fix AbstractSemanticQuickInfoSourceTests.AssertTaggedText to respect expectedClassifications parameter #80785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45893
Problem
The
AssertTaggedTextmethod inAbstractSemanticQuickInfoSourceTestswas ignoring itsexpectedClassificationsparameter. Tests calling methods likeDocumentation(),MainDescription(), etc. withExpectedClassifications()were only validating the concatenated text, not the actual classification tags of eachTaggedTextelement.For example, this test was only checking that the text equals
"This example shows how to specify the GenericClass<T> cref."but not verifying that "GenericClass" has theClassclassification tag:Solution
Modified
AssertTaggedTextto use the existingClassificationTestHelper.VerifyTextAndClassificationsmethod whenexpectedClassificationsis provided. This helper properly validates both:TaggedTextelement has the correct classification tag (e.g.,Class,TypeParameter,Punctuation)When
expectedClassificationsis null, the method continues to use the original simple text comparison, maintaining full backward compatibility.Testing
ExpectedClassificationswill now properly validate classification tagsExpectedClassificationscontinue to work unchangedWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #45893
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.