update pfx to pick better provider #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzikm
approved these changes
Apr 4, 2022
Member
rzikm
left a comment
rzikm
left a comment
There was a problem hiding this comment.
LGTM if it looks good for Jeremy as well.
bartonjs
approved these changes
Apr 4, 2022
Member
Author
|
/backport to release/6.0-staging |
wfurt
added a commit
to wfurt/runtime-assets
that referenced
this pull request
Sep 29, 2023
update pfx to pick better provider
ViktorHofer
pushed a commit
that referenced
this pull request
Oct 2, 2023
update pfx to pick better provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to dotnet/runtime#58927
It seems like the TLS 1.3 is failing because when we import, we pick old CAPI provider. This is generally bug in Schannel but we should be able to move on if we do something better. I don't fully understand what this is happening but the pox crreated according to @bartonjs instructions do work - I did ~ 800 runs without any issue.
before
now