Follow up feedback with logging source generator #52549
Description
Using this issue to keep track of issues to fix based on initial feedback with using source generator:
LoggerMessageAttribute:
- Move Logging Source Generator to MS.Extensions.Logging.Abstractions #52222 Move Logging Source Generator to MS.Extensions.Logging.Abstractions
- Logging generator - for enumerable input argument, add missing helper method #51965 Logging generator - for enumerable input argument, add missing helper method
- Logging-Generator doesn't use LoggerMessage.Define for > 1 template argument #51917 Logging-Generator doesn't use LoggerMessage.Define for > 1 template argument
- LoggerMessage - SYSLIB1008 should have a better message #52221 LoggerMessage - SYSLIB1008 should have a better message
- Logging Source Generator fails with a NullReferenceException #52277 Logging Source Generator fails with a NullReferenceException
- LoggerMessageAttribute should have a constructor that takes EventId, LogLevel, and Message #52276 LoggerMessageAttribute should have a constructor that takes EventId, LogLevel, and Message
- Support nested logging classes in Logging Source Generator #52301 Support nested logging classes in Logging Source Generator
- LoggerMessage - Allow Event ID to be optional #52223 LoggerMessage - Allow Event ID to be optional
- Logging-Generator should allow to skip the IsEnabled check #51927 Logging-Generator should allow to skip the IsEnabled check
- Logging Generator: messaging fix #54008 Logging Generator: messaging fix
Post 6.0 work:
Post-release feedback:
- Logging methods created by generators allocate if LogLevel is passed #61162
- Logging source generator should gracefully fail when special parameters incorrectly get passed as template parameter #64310
- Logging Source Generator fails to compile when
inparameter modifier is present #62644 - Logging Source Generator fails to compile when in parameter modifier is present - Logging Source Generator fails to compile using keyword parameters with @ prefixes #60968 - Logging Source Generator fails to compile using keyword parameters with @ prefixes
- Logging Source Generator fails ungracefully with overloaded methods #61814 - Logging Source Generator fails ungracefully with overloaded methods
- Logging Source Generator fails to compile due to CS0246 and CS0265 errors if type for generic constraint is in a different namespace #58550 - Logging Source Generator fails to compile due to CS0246 and CS0265 errors if type for generic constraint is in a different namespace
- LoggerMessageAttribute generated source does not respect escaped characters and does not compile #56203
In .NET 8.0 timeframe
- [LSG] LoggerMessage source generator generates error when using template destructuring #69490
- [LSG] Logging Source Generator fails to detect event name uniqueness within a class scope #64667
- [LSG] Logging Source Generator fails to compile when
outparameter modifier is present #64665 - [LSG] LoggerMessage - Add diagnostic - Can't have the same template with different casing #52228
- [LSG] LoggerMessage - Add diagnostic - Can't have malformed format strings #52226
- [LSG] LoggerMessage - Add diagnostic when unexpected order provided in message template #52225
- [LSG] warning CS8785: Generator 'LoggerMessageGenerator' failed to generate source. #77525