CI is currently broken "You cannot extract a file outside of the target path"

[eerhardt]

I'm seeing this same error on multiple PRs:

https://dev.azure.com/dnceng/public/_build/results?buildId=1132154&view=logs&j=a4640945-bbdc-597c-ef1f-fa8333a2fcba&t=a98154d0-d3a5-5a2b-9381-8130b5ef9cd5&l=44

https://dev.azure.com/dnceng/public/_build/results?buildId=1132211&view=logs&j=f827f174-7a88-54e3-54c2-8dcd28f39edd&t=102b6136-808d-5b02-a12e-313a3079cf99&l=45

Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.079 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 4
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.103 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 3
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.132 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 2
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 27.139 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 1
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.118 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
##[error]Failed in Download zip - CoreCLRProduct___windows_arm64_release with error: Failed to extract package with error Error: You cannot extract a file outside of the target path
Successfully downloaded artifacts to D:\workspace\_work\1\s/__download__
##[error]Failed to extract package with error Error: You cannot extract a file outside of the target path

Runfo Tracking Issue: Failure to extract packages

Definition	Build	Kind	Job Name

Build Result Summary

Day Hit Count	Week Hit Count	Month Hit Count
0	0	0

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

I'm seeing this same error on multiple PRs:

https://dev.azure.com/dnceng/public/_build/results?buildId=1132154&view=logs&j=a4640945-bbdc-597c-ef1f-fa8333a2fcba&t=a98154d0-d3a5-5a2b-9381-8130b5ef9cd5&l=44

https://dev.azure.com/dnceng/public/_build/results?buildId=1132211&view=logs&j=f827f174-7a88-54e3-54c2-8dcd28f39edd&t=102b6136-808d-5b02-a12e-313a3079cf99&l=45

Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.079 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 4
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.103 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 3
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 23.132 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 2
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 27.139 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
Error: in Download zip - CoreCLRProduct___windows_arm64_release, so retrying => retries pending  : 1
Downloading artifact CoreCLRProduct___windows_arm64_release from: https://dev.azure.com/dnceng//9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_apis/build/builds/1132154/artifacts?artifactName=CoreCLRProduct___windows_arm64_release&$format=zip
Downloading  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Downloaded  to D:\workspace\_work\1\s\__download__\CoreCLRProduct___windows_arm64_release.zip
Total Files: 1, Processed: 1, Skipped: 0, Failed: 0, Download time: 21.118 secs, Download size: 0Bytes
Starting artifact items integrity check
Artifact items integrity check successfully finished
##[error]Failed in Download zip - CoreCLRProduct___windows_arm64_release with error: Failed to extract package with error Error: You cannot extract a file outside of the target path
Successfully downloaded artifacts to D:\workspace\_work\1\s/__download__
##[error]Failed to extract package with error Error: You cannot extract a file outside of the target path

Author:	eerhardt
Assignees:	-
Labels:	area-Infrastructure-coreclr, blocking-clean-ci
Milestone:	-

[Chrisboh]

@dotnet/dnceng could you take a look at this and see if this is part of the AzDo issues we are currently seeing?

[ericstj]

Has anyone inspected the ZIP to see if it has malformed entries? Things like a rooted (\foo) or relative (..) archive entry might cause that error.

[jaredpar]

Seeing 700+ hits over last seven days

https://runfo.azurewebsites.net/search/timelines/?q=started%3A%7E7+definition%3Aruntime+message%3A%22You+cannot+extract+a+file+outside+of+the+target+path%22

[hoyosjs]

Also, a quick scan through the hits I saw on runfo - all of them seem to be on Windows. Before most of our corruption at download was seen on Linux/macOS. @ericstj this is at download time, so unlikely. The only validation done at this stage on the artifact is that the file size matches the size in the manifest (this was added in microsoft/azure-pipelines-tasks#14065). I am wondering if the asset manifest is correct here, or if it matches whatever typescript considers to be file size when checking the artifact in https://github.com/microsoft/azure-pipelines-tasks/blob/c9771bc064cd60f47587c68e5c871b7cd13f0f28/Tasks/DownloadBuildArtifactsV0/download_helper.ts#L37.

[chcosta]

Thanks for reporting this, I'm taking a look.

[hoyosjs]

@chcosta I just checked this manually. The manifest size and the size reported by powershell on the asset reported in the issue and they do differ quite a bit: 208496577 in manifest vs 207457787 in pwsh.