-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Labels
area-System.Net.QuicenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions
Milestone
Description
I noticed this while reviewing #53461.
namespace System.Net.Quic.Implementations.MsQuic.Internal
{
internal static class MsQuicAddressHelpers
{
internal const ushort IPv4 = 2;
internal const ushort IPv6 = 23;
..
internal static SOCKADDR_INET IPEndPointToINet(IPEndPoint endpoint)
{
socketAddress.Ipv6._family = IPv6;AF_INET6 is 10 on Linux and 30 on macOS. It feels like this should come from PAL.
It also seems like our tests use CreateQuicListener() that use IPEndPoint(IPAddress.Loopback, 0) so we may have test gaps for IPv6.
Metadata
Metadata
Assignees
Labels
area-System.Net.QuicenhancementProduct code improvement that does NOT require public API changes/additionsProduct code improvement that does NOT require public API changes/additions