Libraries packaging should support including roslyn generated documentation xml file

[safern]

Currently all the documentation files that we include in our packages come from the intellisense package we consume from the docs team. However, some projects have already ported their documentation to triple slash, so we should be packaging the resulted xml file from the roslyn compilation on those projects.

In order to support that we should introduce a property, maybe IncludeDocumentationFromSource, and have the infra choose the generated file rather than the downloaded one: #54250 (comment)

cc: @carlossanlop @ViktorHofer @Anipik @ericstj

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Currently all the documentation files that we include in our packages come from the intellisense package we consume from the docs team. However, some projects have already ported their documentation to triple slash, so we should be packaging the resulted xml file from the roslyn compilation on those projects.

In order to support that we should introduce a property, maybe IncludeDocumentationFromSource, and have the infra choose the generated file rather than the downloaded one: #54250 (comment)

cc: @carlossanlop @ViktorHofer @Anipik @ericstj

Author:	safern
Assignees:	-
Labels:	area-Infrastructure-libraries, documentation
Milestone:	6.0.0

[safern]

Moving to 7.0.0 as the plan for 6.0 is to keep dotnet-api-docs as the source of truth even for the docs that have been ported as the tool has some issues that need to be fixed.

cc: @jeffhandley

[ViktorHofer]

Closing as this was implemented via the UseIntellisenseDocumentationFile switch which defaults to true if the intellisense file exists:

runtime/eng/packaging.targets

Line 27 in 7084d44

<UseIntellisenseDocumentationFile Condition="'$(UseIntellisenseDocumentationFile)' == '' and Exists('$(LibIntellisenseDocumentationFilePath)')">true</UseIntellisenseDocumentationFile>

Unrelated to this issue but still important is to make sure that this switch is honored when binplacing the documentation files into the targeting pack.

[safern]

Closing as this was implemented via the UseIntellisenseDocumentationFile switch which defaults to true if the intellisense file exists:

To give some context to people that read this issue, intellisense documentation file is the one that comes from the generated intellisense nuget package from the docs repo. The goal is to set this property to false in all our projects by porting the docs to source (triple slash) and once we are there we can remove this switch entirely.