Extra file exist check in FileSystem.MoveDirectory on Unix

[iSazonov]

Description

See

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

Lines 373 to 376 in 4809039

	public static void MoveDirectory(string sourceFullPath, string destFullPath)
	{
	// Windows doesn't care if you try and copy a file via "MoveDirectory"...
	if (FileExists(sourceFullPath))

There are two places where the FileSystem.MoveDirectory helper is used and in both places there is already the same check.

(The comment for Windows in the code is also weird.)

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

See

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

Lines 373 to 376 in 4809039

	public static void MoveDirectory(string sourceFullPath, string destFullPath)
	{
	// Windows doesn't care if you try and copy a file via "MoveDirectory"...
	if (FileExists(sourceFullPath))

There are two places where the FileSystem.MoveDirectory helper is used and in both places there is already the same check.

Author:	iSazonov
Assignees:	-
Labels:	area-System.IO, tenet-performance, untriaged
Milestone:	-

[carlossanlop]

Yes, there are two FileExists checks, but the first one is for the source path, and the second one is for the destination path. Since there is no bug or potential improvement we could make, I'll go ahead and close the issue.

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

Line 376 in 4809039

if (FileExists(sourceFullPath))

runtime/src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Unix.cs

Line 393 in 4809039

if (FileExists(destFullPath))