Linux: Instantiating a LdapConnection with a server string including a port number in .Net6.0-rc1 System.DirectoryServices.Protocols throws later an error at a SendRequest

[p3rdu]

Description

If you instantiate a LdapConnection with a string consisting from a server name and a port number e.g.

LdapConnection ldap = new LdapConnection("ldap.example.com:636");

then a later method call like

DirectoryResponse dResp = ldap.SendRequest(request);

yields

Exception has occurred: CLR/System.DirectoryServices.Protocols.LdapException
An unhandled exception of type 'System.DirectoryServices.Protocols.LdapException' occurred in System.DirectoryServices.Protocols.dll: 'A bad parameter was passed to a routine.'
   at System.DirectoryServices.Protocols.LdapConnection.Connect()
   at System.DirectoryServices.Protocols.LdapConnection.SendRequestHelper(DirectoryRequest request, Int32& messageID)
   at System.DirectoryServices.Protocols.LdapConnection.SendRequest(DirectoryRequest request, TimeSpan requestTimeout)
   at System.DirectoryServices.Protocols.LdapConnection.SendRequest(DirectoryRequest request)

However when instantiating the LdapConnection in this manner

LdapConnection ldap = new LdapConnection(new LdapDirectoryIdentifier("ldap.example.com",636));

then same SendRequest works without exceptions.

Documentation at

.Net Documentation System_DirectoryServices_Protocols_LdapConnection__ctor_System_String_

states that

server String
A string specifying the server which can be a domain name, LDAP server name or dotted strings representing the IP address of the LDAP server. Optionally, this parameter may also include a port number, separated from the right end of the string by a colon (:).

Configuration

.Net6-rc1 Linux Ubuntu 18.04 x86-64

Regression?

Don't know.

Other information

Tagging subscribers to this area: @jay98014
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

If you instantiate a LdapConnection with a string consisting from a server name and a port number e.g.

LdapConnection ldap = new LdapConnection("ldap.example.com:636");

then a later method call like

DirectoryResponse dResp = ldap.SendRequest(request);

yields

Exception has occurred: CLR/System.DirectoryServices.Protocols.LdapException
An unhandled exception of type 'System.DirectoryServices.Protocols.LdapException' occurred in System.DirectoryServices.Protocols.dll: 'A bad parameter was passed to a routine.'
   at System.DirectoryServices.Protocols.LdapConnection.Connect()
   at System.DirectoryServices.Protocols.LdapConnection.SendRequestHelper(DirectoryRequest request, Int32& messageID)
   at System.DirectoryServices.Protocols.LdapConnection.SendRequest(DirectoryRequest request, TimeSpan requestTimeout)
   at System.DirectoryServices.Protocols.LdapConnection.SendRequest(DirectoryRequest request)

However when instantiating the LdapConnection in this manner

LdapConnection ldap = new LdapConnection(new LdapDirectoryIdentifier(ldap.example.com,636));

then same SendRequest works without exceptions.

Documentation at

.Net Documentation System_DirectoryServices_Protocols_LdapConnection__ctor_System_String_

states that

server String
A string specifying the server which can be a domain name, LDAP server name or dotted strings representing the IP address of the LDAP server. Optionally, this parameter may also include a port number, separated from the right end of the string by a colon (:).

Configuration

.Net6-rc1 Linux Ubuntu 18.04 x86-64

Regression?

Don't know.

Other information

Author:	p3rdu
Assignees:	-
Labels:	area-System.DirectoryServices, untriaged
Milestone:	-

[joperezr]

Thanks for finding this issue and for logging it @p3rdu. We should be consistent to how Windows currently works here, which by looking at the documentation that you found, then we should likely be parsing this and setting the port accordingly. Did you get a chance to check if this works in Windows? I'm marking this issue as up-for-grabs in case anyone wants to get a stab at it before we get to it.

[filipjelic]

Hey @joperezr. I'd like to work on this ticket.
Before coding, just a small discussion since I see what the issue is.

The LdapDirectoryIdentifier not only accepts a server it also accepts servers. The default constructor is accepting array of servers.
Currently we have 5 default constructors, and all of them are pointing to the base one who is accepting list of servers.
There is one constructor which requires attention.
As you can tell, it accepts a array of servers and a portNumber.
Two questions.

• Should the passed port number be default for all servers
• Should we check if servers in the collection have port number and throw an exception if they do?

[joperezr]

Thanks for volunteering @filipjelic. The main thing to track on this issue is that there shouldn't be inconsistencies between Windows and Linux behaviors, so if the port number passed in to this constructor is defaulted to all servers in Windows, we would want to match that on Linux too. For your second question, I wouldn't add that. When calling the constructor of the LdapConnection we are just creating a native handle of that connection, but not yet performing any sort of validation just yet. If the specified port is closed, I think that what should happen naturally is that constructor shouldn't throw an exception, and instead when calling Bind() the exception should be thrown as I believe happens today.