JIT assert on arm64 when running DllImportGenerator tests: op2->TypeIs(TYP_LONG)

[AndyAyersMS]

https://dev.azure.com/dnceng/public/_build/results?buildId=1429275&view=ms.vss-test-web.build-test-results-tab

/root/helix/work/correlation/dotnet exec --runtimeconfig DllImportGenerator.Tests.runtimeconfig.json --depsfile DllImportGenerator.Tests.deps.json xunit.console.dll DllImportGenerator.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: DllImportGenerator.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  DllImportGenerator.Tests (found 94 test cases)
  Starting:    DllImportGenerator.Tests (parallel test collections = on, max threads = 4)

Assert failure(PID 27 [0x0000001b], Thread: 40 [0x0028]): Assertion failed 'op2->TypeIs(TYP_LONG)' in 'Arrays:AndAllMembers(SharedTypes.BoolStruct[],int):bool' during 'Lowering nodeinfo' (IL size 180)

    File: /__w/2/s/src/coreclr/jit/gentree.cpp Line: 2449
    Image: /root/helix/work/correlation/dotnet

also seen in some PGO testing I did.

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

---

https://dev.azure.com/dnceng/public/_build/results?buildId=1429275&view=ms.vss-test-web.build-test-results-tab

/root/helix/work/correlation/dotnet exec --runtimeconfig DllImportGenerator.Tests.runtimeconfig.json --depsfile DllImportGenerator.Tests.deps.json xunit.console.dll DllImportGenerator.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing 
popd
===========================================================================================================
/root/helix/work/workitem/e /root/helix/work/workitem/e
  Discovering: DllImportGenerator.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  DllImportGenerator.Tests (found 94 test cases)
  Starting:    DllImportGenerator.Tests (parallel test collections = on, max threads = 4)

Assert failure(PID 27 [0x0000001b], Thread: 40 [0x0028]): Assertion failed 'op2->TypeIs(TYP_LONG)' in 'Arrays:AndAllMembers(SharedTypes.BoolStruct[],int):bool' during 'Lowering nodeinfo' (IL size 180)

    File: /__w/2/s/src/coreclr/jit/gentree.cpp Line: 2449
    Image: /root/helix/work/correlation/dotnet

also seen in some PGO testing I did.

Author:	AndyAyersMS
Assignees:	-
Labels:	area-CodeGen-coreclr, untriaged
Milestone:	-

[SingleAccretion]

Possibly easier reproduction:

@@ -4626,6 +4626,12 @@ void Lowering::ContainCheckMul(GenTreeOp* node)
     assert(node->OperIs(GT_MUL, GT_MULHI));
 #endif

+    if (node->OperIs(GT_MUL) && node->TypeIs(TYP_LONG))
+    {
+        assert(node->gtGetOp1()->TypeIs(TYP_LONG));
+        assert(node->gtGetOp2()->TypeIs(TYP_LONG));
+    }
+

Run SPMI on Windows x64 and see the following trees running around...

[000251] ---------U-- >>>          *  MUL       long
[000250] ------------              +--*  RSZ       int
[000020] ------------              |  +--*  LCL_VAR   int    V04 loc0         u:2 <l:$249, c:$248>
[000249] -c----------              |  \--*  CNS_INT   int    2
[000021] -------N----              \--*  CNS_INT   long   0x396B207F $48

Edit: or not, this appears to be a different issue.

[AaronRobinsonMSFT]

/cc @jkoritzinsky @elinor-fung