Skip to content

Http2's SendPingAsync may leak UnobservedTaskExceptions #64450

@MihaZupan

Description

@MihaZupan

(based on code inspection)

The SendPingAsync call that we do as part of the ConnectionPoolManager's heartbeat isn't awaited and so any exceptions from it would bubble up as UnobservedTaskExceptions.

We should consume the task with LogExceptions(SendPingAsync(pingPayload)) as we do when sending out pings normally.

Should be an easy fix - marking as up for grabs.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions