[External] zlib has suppressed warnings

[AaronRobinsonMSFT]

The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream.

zlib

runtime/src/native/external/zlib-intel.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/native/external/zlib.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/mono/mono/mini/CMakeLists.txt

Line 341 in 6c3c234

set_source_files_properties(${ZLIB_SOURCES} PROPERTIES COMPILE_OPTIONS "/wd4005;/wd4127;/wd4131;/wd4244")

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream.

zlib

runtime/src/native/external/zlib-intel.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/native/external/zlib.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/mono/mono/mini/CMakeLists.txt

Line 341 in 6c3c234

set_source_files_properties(${ZLIB_SOURCES} PROPERTIES COMPILE_OPTIONS "/wd4005;/wd4127;/wd4131;/wd4244")

libunwind

runtime/src/native/external/libunwind_extras/CMakeLists.txt

Line 143 in 5609534

add_compile_options(-wd4244) # possible loss of data

Author:	AaronRobinsonMSFT
Assignees:	-
Labels:	area-Meta
Milestone:	8.0.0

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The following externally consumed projects require suppression of warnings that are unadvised. We should be fixing these issues and offering those fixes upstream.

zlib

runtime/src/native/external/zlib-intel.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/native/external/zlib.cmake

Line 2 in 89962a5

add_compile_options($<$<COMPILE_LANGUAGE:C,CXX>:/wd4244>) # conversion from 'type1' to 'type2', possible loss of data

runtime/src/mono/mono/mini/CMakeLists.txt

Line 341 in 6c3c234

set_source_files_properties(${ZLIB_SOURCES} PROPERTIES COMPILE_OPTIONS "/wd4005;/wd4127;/wd4131;/wd4244")

libunwind

runtime/src/native/external/libunwind_extras/CMakeLists.txt

Line 143 in 5609534

add_compile_options(-wd4244) # possible loss of data

Author:	AaronRobinsonMSFT
Assignees:	-
Labels:	area-System.IO.Compression
Milestone:	8.0.0

[danmoseley]

Could this be help wanted label?

[GrabYourPitchforks]

C4244 was addressed via #91245 and the zlib patch will be merged upstream in 1.3.1.1.

IIRC the mono build work is still outstanding.

[ericstj]

I believe this is now resolved with the move to zlib-ng and #105433 cc @carlossanlop