[Hot Reload] metadata.c:1326, condition `GINT_TO_UINT32(idx) < table_info_get_rows (t)' not met

[rolfbjarne]

From @jeromelaban on Fri, 20 Oct 2023 03:53:31 GMT

Steps to Reproduce

1. Create a maui app (net8 rc2)
2. Add a [CreateNewOnMetadataUpdate] attribute on MainPage
3. Build the app
4. Run the app
5. Add a ToString(); call in the ctor, or any other MainPage modification
6. Perform a C# hot reload

Expected Behavior

The code is updated without crashing.

Actual Behavior

Sometimes:

error: * Assertion at /Users/runner/work/1/s/src/mono/mono/metadata/metadata.c:1326, condition `GINT_TO_UINT32(idx) < table_info_get_rows (t)' not met

Sometimes:

=================================================================
	Native Crash Reporting
=================================================================
Got a SIGSEGV while executing native code. This usually indicates
a fatal error in the mono runtime or one of the native libraries 
used by your application.
=================================================================

=================================================================
	Native stacktrace:
=================================================================
	0x104aba1d5 - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmonosgen-2.0.dylib : mono_dump_native_crash_info
	0x104a58b6e - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmonosgen-2.0.dylib : mono_handle_native_crash
	0x1049abaff - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmonosgen-2.0.dylib : mono_sigsegv_signal_handler_debug
	0x7ff8377405ed - /usr/lib/system/libsystem_platform.dylib : _sigtramp
	0x0 - Unknown
	0x103b33fd6 - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmono-component-debugger.dylib : get_types_for_source_file
	0x103b3ce1d - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmono-component-debugger.dylib : monoeg_g_hash_table_foreach
	0x103b25917 - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmono-component-debugger.dylib : mono_process_dbg_packet
	0x103b2d3ff - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmono-component-debugger.dylib : mono_debugger_agent_receive_and_process_command
	0x103b300f0 - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmono-component-debugger.dylib : debugger_thread
	0x104bbb4fe - /Users/jay2/Library/Developer/CoreSimulator/Devices/F4A03A05-42EF-47DF-8C0B-0DB5B0E49D76/data/Containers/Bundle/Application/FD06AA1D-DB01-4BC1-B692-B59CC36FB231/MauiApp3.app/libmonosgen-2.0.dylib : start_wrapper
	0x7ff83774d1d3 - /usr/lib/system/libsystem_pthread.dylib : _pthread_start
	0x7ff837748bd3 - /usr/lib/system/libsystem_pthread.dylib : thread_start

Environment

• VS 2022 17.8 Preview 4
• .NET 8.0.100-rc.2.23502.2

Installed Workload Id      Manifest Version                     Installation Source
----------------------------------------------------------------------------------------------------------------------
maui-ios                   8.0.0-rc.2.9373/8.0.100-rc.2         VS 17.7.34009.444
ios                        16.4.8968-net8-rc2/8.0.100-rc.2      VS 17.7.34009.444, VS 17.8.34212.112, VS 17.8.34112.27
maccatalyst                16.4.8968-net8-rc2/8.0.100-rc.2      VS 17.7.34009.444, VS 17.8.34212.112, VS 17.8.34112.27
maui-android               8.0.0-rc.2.9373/8.0.100-rc.2         VS 17.7.34009.444
android                    34.0.0-rc.2.468/8.0.100-rc.2         VS 17.7.34009.444, VS 17.8.34212.112, VS 17.8.34112.27
maui-windows               8.0.0-rc.2.9373/8.0.100-rc.2         VS 17.7.34009.444, VS 17.8.34212.112, VS 17.8.34112.27
maui-maccatalyst           8.0.0-rc.2.9373/8.0.100-rc.2         VS 17.7.34009.444

Build Logs

Available on demand.

Copied from original issue dotnet/macios#19277

[rolfbjarne]

From @rolfbjarne on Fri, 20 Oct 2023 08:44:49 GMT

@jeromelaban this looks like a crash in the debugger; does the app run if you don't attach a debugger (just tap on it)?

[rolfbjarne]

From @jeromelaban on Fri, 20 Oct 2023 11:30:28 GMT

@rolfbjarne thanks for looking into it! No, the app does not crash, but there's no hot reload that can happen either. The issue only happens when explicitly triggering a hot reload (which happens through the debugger in this case).

It may be a runtime issue, though, since it fails in a very similar way under Android.

I can open a runtime issue if you think it's more appropriate.

[rolfbjarne]

From @jeromelaban on Fri, 20 Oct 2023 12:36:24 GMT

@rolfbjarne I just discovered that I missed some steps in the original description, my apologies. Hot reloading is required for this to fail.

[rolfbjarne]

From @rolfbjarne on Mon, 23 Oct 2023 12:15:07 GMT

I can open a runtime issue if you think it's more appropriate.

Yes, this looks like a runtime issue, so the dotnet/runtime repository would be a better place for it.

I'll move it there.

[jeromelaban]

@rolfbjarne I was under the impression that using System.Reflection.Metadata.MetadataUpdater.ApplyUpdate was more stable, but it's still failing with this same error (when compared to the debugger doing the same through its own APIs), sometimes immediately, sometimes after a few updates.

[jeromelaban]

Also, the issue happens on webassembly, which makes sense as it's mono underneath. (/cc @lewing)

[lambdageek]

CreateNewOnMetadataUpdate is hard to use (the old class name is still around and valid) and I don't think Maui has been updated to use it (although I could be wrong). But the runtime crash is not expected.

[lambdageek]

@jeromelaban do you have separate repro steps for Wasm? I think it's probably crashing in a different place for the same underlying reason. It would be helpful to see the other stack trace

[jeromelaban]

@lambdageek I'll try to build one using blazor.

In the meantime it really is almost the same place, probably in slight version differences:

[MONO] * Assertion at /__w/runtime/src/mono/mono/metadata/metadata.c:1321, condition `GINT_TO_UINT32(idx) < table_info_get_rows (t)' not met

    at mono_wasm_stringify_as_error_with_stack (dotnet.js:5:620)
    at Object.mono_wasm_trace_logger (dotnet.js:5:985)
    at _mono_wasm_trace_logger (dotnet.js:14:111110)
    at dotnet.wasm:0x9f18
    at dotnet.wasm:0xabc71
    at dotnet.wasm:0x1c8ae2
    at dotnet.wasm:0x1c8b41
    at dotnet.wasm:0x1c8b75
    at dotnet.wasm:0x822de
    at dotnet.wasm:0x821ff