NativeAOT publish fails on fi_FI.utf8 locale

[De-Crypted]

Describe the bug

Trying to publish freshly created console application with dotnet publish /p:PublishAot=true produces error:

MSBuild version 17.9.4+90725d08d for .NET
/home/user/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.2/build/Microsoft.DotNet.ILCompiler.SingleEntry.targets(9,16): error MSB4086: A numeric comparison was attempted on "$(_indexOfPeriod)" that evaluates to "−1" instead of a number, in condition "'$(_indexOfPeriod)' > -1". [/home/user/sources/project/daemon/daemon.csproj]

Note that the first -1 actually has "U+2212 : MINUS SIGN" printed in the console.

As a workaround locale can be set to en_US.utf8 and the publish works as expected.

To Reproduce

On Linux machine set locale to fi_FI.utf8
Create console application with

dotnet new console -n app

Publish it with

dotnet publish /p:PublishAot=true

Further technical details

.NET SDK:
 Version:           8.0.200
 Commit:            438cab6a9d
 Workload version:  8.0.200-manifests.cdf2cc8e

Runtime Environment:
 OS Name:     manjaro
 OS Version:  
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /home/tk/.dotnet/sdk/8.0.200/

.NET workloads installed:
There are no installed workloads to display.

Host:
  Version:      8.0.2
  Architecture: x64
  Commit:       1381d5ebd2

.NET SDKs installed:
  8.0.200 [/home/tk/.dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.2 [/home/tk/.dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.2 [/home/tk/.dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/share/dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Describe the bug

Trying to publish freshly created console application with dotnet publish /p:PublishAot=true produces error:

MSBuild version 17.9.4+90725d08d for .NET
/home/user/.nuget/packages/microsoft.dotnet.ilcompiler/8.0.2/build/Microsoft.DotNet.ILCompiler.SingleEntry.targets(9,16): error MSB4086: A numeric comparison was attempted on "$(_indexOfPeriod)" that evaluates to "−1" instead of a number, in condition "'$(_indexOfPeriod)' > -1". [/home/user/sources/project/daemon/daemon.csproj]

Note that the first -1 actually has "U+2212 : MINUS SIGN" printed in the console.

As a workaround locale can be set to en_US.utf8 and the publish works as expected.

To Reproduce

On Linux machine set locale to fi_FI.utf8
Create console application with

dotnet new console -n app

Publish it with

dotnet publish /p:PublishAot=true

Further technical details

.NET SDK:
 Version:           8.0.200
 Commit:            438cab6a9d
 Workload version:  8.0.200-manifests.cdf2cc8e

Runtime Environment:
 OS Name:     manjaro
 OS Version:  
 OS Platform: Linux
 RID:         linux-x64
 Base Path:   /home/tk/.dotnet/sdk/8.0.200/

.NET workloads installed:
There are no installed workloads to display.

Host:
  Version:      8.0.2
  Architecture: x64
  Commit:       1381d5ebd2

.NET SDKs installed:
  8.0.200 [/home/tk/.dotnet/sdk]

.NET runtimes installed:
  Microsoft.AspNetCore.App 8.0.2 [/home/tk/.dotnet/shared/Microsoft.AspNetCore.App]
  Microsoft.NETCore.App 8.0.2 [/home/tk/.dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
  None

Environment variables:
  DOTNET_ROOT       [/usr/share/dotnet]

global.json file:
  Not found

Learn more:
  https://aka.ms/dotnet/info

Download .NET:
  https://aka.ms/dotnet/download

Author:	De-Crypted
Assignees:	-
Labels:	untriaged, area-NativeAOT-coreclr
Milestone:	-

[akoeplinger]

It looks like <_indexOfPeriod>$(_originalTargetOS.IndexOf('.'))</_indexOfPeriod> causes the int->string conversion to happen with current culture:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.DotNet.ILCompiler.SingleEntry.targets

Lines 8 to 9 in 7185df8

	<_indexOfPeriod>$(_originalTargetOS.IndexOf('.'))</_indexOfPeriod>
	<_originalTargetOS Condition="'$(_indexOfPeriod)' &gt; -1">$(_originalTargetOS.SubString(0, $(_indexOfPeriod)))</_originalTargetOS>

[akoeplinger]

We can't use .ToString(CultureInfo.InvariantCulture) since CultureInfo is not allowed in msbuild.

A workaround I found is using .ToString('0;-0') to use an explicit minus sign for negative numbers in the format string.
Or we could just duplicate the .IndexOf() call instead of using the msbuild property as an intermediate.

Any preferences?

[tmds]

.NET SDKs installed:
8.0.200 [/home/tk/.dotnet/sdk]

I wonder if you're seeing this because of dotnet/msbuild#9449.

If you export MSBUILDDISABLEFEATURESFROMVERSION=17.10, does it work?

[akoeplinger]

@tmds I don't think so, that PR only changes the culture of the Exec task which is not used here.

[MichalStrehovsky]

We can't use .ToString(CultureInfo.InvariantCulture) since CultureInfo is not allowed in msbuild.

A workaround I found is using .ToString('0;-0') to use an explicit minus sign for negative numbers in the format string. Or we could just duplicate the .IndexOf() call instead of using the msbuild property as an intermediate.

Any preferences?

Maybe duplicating would be better. We can use Contains to make a it bit more readable, although it still looks like LISP.

<_originalTargetOS Condition="$(_originalTargetOS.Contains('.'))">$(_originalTargetOS.SubString(0, $(_originalTargetOS.IndexOf('.'))))</_originalTargetOS>