JIT: Fix mangleVarArgsType for SIMD types #100278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning `TYP_INT` from this function was causing `lvaInitUserArgs` to not set the "other reg" in `LclVarDsc` for SIMD types in varargs methods. This seemingly didn't usually cause issues, probably because we always DNER them and apparently `genFnPrologCalleeRegArgs` does not use `LclVarDsc::GetOtherArgReg()` in this case.
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS |
AndyAyersMS
approved these changes
Mar 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning
TYP_INTfrom this function was causinglvaInitUserArgsto not set the "other reg" inLclVarDscfor SIMD types in varargs methods. This seemingly didn't usually cause issues, probably because we always DNER them and apparentlygenFnPrologCalleeRegArgsdoes not useLclVarDsc::GetOtherArgReg()in this case.Split out from #100276