Skip to content

Conversation

@liveans
Copy link
Member

@liveans liveans commented Apr 4, 2024

Fixes #85331. This is already covered by stress tests.

@liveans liveans requested a review from a team April 4, 2024 14:18
@ghost ghost added the area-System.Net.Quic label Apr 4, 2024
@liveans liveans merged commit cf38265 into dotnet:main Apr 4, 2024
@liveans
Copy link
Member Author

liveans commented Apr 4, 2024

I believe we should backport this to 7.0 and 8.0 as well. Most of the noise is coming from there.

@ManickaP
Copy link
Member

/backport to release/8.0-staging

@github-actions github-actions bot unlocked this conversation May 23, 2024
@github-actions
Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/9209776014

@github-actions
Copy link
Contributor

@ManickaP backporting to release/8.0-staging failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Delete test which is already covered by stress
Using index info to reconstruct a base tree...
M	src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
CONFLICT (content): Merge conflict in src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicTests.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Delete test which is already covered by stress
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@ManickaP an error occurred while backporting to release/8.0-staging, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test Failure] System.Net.Quic.Tests.MsQuicTests.ByteMixingOrNativeAVE_MinimalFailingTest

4 participants