Remove some volatile use on objects in corelib #100969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-meta |
jkotas
approved these changes
Apr 12, 2024
|
It's motivated by @VSadov citing earlier this week that such usage still results in extra fences being emitted on arm (I don't have a machine handy to test on). If that's not the case, or if we can teach the jit somehow they can be elided, I agree it's better to leave them. If not, seems like unnecessary overhead. |
xtqqczze
reviewed
Apr 13, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs
Outdated
Show resolved
Hide resolved
VSadov
reviewed
Apr 13, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
Show resolved
Hide resolved
VSadov
reviewed
Apr 13, 2024
src/libraries/System.Private.CoreLib/src/System/Threading/LazyInitializer.cs
Outdated
Show resolved
Hide resolved
jkotas
previously requested changes
Apr 13, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureInfo.cs
Outdated
Show resolved
Hide resolved
stephentoub
force-pushed
the
removevolatile
branch
from
776ab3c to
7508d98
Compare
From a review of the use, all of this use for lazy initialization now appears to be superfluous, given our documented memory model.
stephentoub
force-pushed
the
removevolatile
branch
from
7508d98 to
f30b470
Compare
jkotas
approved these changes
Apr 19, 2024
This was referenced Apr 19, 2024
xtqqczze
reviewed
Apr 19, 2024
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.cs
Show resolved
Hide resolved
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
From a review of the use, all of this use for lazy initialization now appears to be superfluous, given our documented memory model.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a review of usage sites, all of this use for lazy initialization now appears to be superfluous, given our documented memory model.